Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 13375002: Revert issue 158379 (chrome.window.create height) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index 5e2a0fce521f3c8bf94bff420e3d3c7fa6fa0ed0..ab823620585d9b0a1cc668b88eedbe07b24ed05a 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -402,6 +402,19 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_WindowOpener) {
ASSERT_TRUE(RunExtensionTest("window_open/opener")) << message_;
}
+#if defined(OS_MACOSX)
+// Extension popup windows are incorrectly sized on OSX, crbug.com/225601
+#define MAYBE_WindowOpenSized DISABLED_WindowOpenSized
+#else
+#define MAYBE_WindowOpenSized WindowOpenSized
+#endif
+// Ensure that the width and height properties of a window opened with
+// chrome.windows.create match the creation parameters. See crbug.com/173831.
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_WindowOpenSized) {
+ ASSERT_TRUE(RunExtensionTest("window_open/window_size")) << message_;
+ EXPECT_TRUE(WaitForTabsAndPopups(browser(), 0, 1, 0));
+}
+
// Tests that an extension page can call window.open to an extension URL and
// the new window has extension privileges.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenExtension) {
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698