Issue 133743005: Don't allow windowed but not pinned applications to mix with shortcuts in the shelf launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133743005: Don't allow windowed but not pinned applications to mix with shortcuts in the shelf launcher (Closed)

Created:
6 years, 11 months ago by Mr4D (OOO till 08-26)

Modified:
6 years, 11 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, Harry McCleave

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't allow windowed but not pinned applications to mix with shortcuts in the shelf launcher At the moment running windowed applications can be mixed with pinned applications - which is incorrect (checked with kuscher). This CL is a pre-CL for the order preservation of all running applications in multi profile mode (trying to keep it small). BUG=309029 TEST=unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244416

Patch Set 1 #

Patch Set 2 : Self nit: Changed comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	ash/shelf/shelf_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/133743005/30001

6 years, 11 months ago (2014-01-10 23:43:53 UTC) #3

Message was sent while issue was closed.

Change committed as 244416

Expand Messages | Collapse Messages