Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Issue 133743005: Don't allow windowed but not pinned applications to mix with shortcuts in the shelf launcher (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self nit: Changed comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
index 634ff70848ceb918014e4e13c6e084fce9172157..405859513705b0661d39f6d47b0bf611d6f096f5 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
@@ -1756,18 +1756,15 @@ TEST_F(ChromeLauncherControllerTest, RestoreDefaultAndLockedAppsResyncOrder) {
// Going back to a status where there is no requirement for app 2 to be pinned
// should convert it back to locked but not pinned and state. The position
- // is determined by the |ShelfModel|'s weight system. Since at the moment
- // the weight of a running app has the same as a shortcut, it will remain
- // where it is. Surely note ideal, but since the sync process can shift around
- // locations - as well as many other edge cases - this gets nearly impossible
- // to get right.
- // TODO(skuhne): Filed crbug.com/293761 to track of this.
+ // is determined by the |ShelfModel|'s weight system and since running
+ // applications are not allowed to be mixed with shortcuts, it should show up
+ // at the end of the list.
base::ListValue policy_value2;
InsertPrefValue(&policy_value2, 0, extension3_->id());
InsertPrefValue(&policy_value2, 1, extension1_->id());
profile()->GetTestingPrefService()->SetUserPref(prefs::kPinnedLauncherApps,
policy_value2.DeepCopy());
- EXPECT_EQ("AppList, Chrome, App3, app2, App1, ", GetPinnedAppStatus());
+ EXPECT_EQ("AppList, Chrome, App3, App1, app2, ", GetPinnedAppStatus());
// Removing an item should simply close it and everything should shift.
base::ListValue policy_value3;
« no previous file with comments | « ash/shelf/shelf_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698