Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: Source/platform/mediastream/MediaStreamSource.h

Issue 133733004: Adding owner access from WebMediaStreamTrack::ExtraData (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/exported/WebMediaStreamSource.cpp ('k') | public/platform/WebMediaStreamTrack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/mediastream/MediaStreamSource.h
diff --git a/Source/platform/mediastream/MediaStreamSource.h b/Source/platform/mediastream/MediaStreamSource.h
index 737bc9719bad4719aa69d65fcbdc60fc3be25714..4e40f45ff02e2cbf3e07799ff75f4f949e2e1024 100644
--- a/Source/platform/mediastream/MediaStreamSource.h
+++ b/Source/platform/mediastream/MediaStreamSource.h
@@ -52,7 +52,7 @@ public:
virtual void sourceChangedState() = 0;
};
- class ExtraData {
+ class ExtraData : public RefCounted<ExtraData> {
public:
virtual ~ExtraData() { }
};
@@ -81,7 +81,7 @@ public:
void removeObserver(Observer*);
ExtraData* extraData() const { return m_extraData.get(); }
- void setExtraData(ExtraData* extraData) { m_extraData = adoptPtr(extraData); }
+ void setExtraData(PassRefPtr<ExtraData> extraData) { m_extraData = extraData; }
void setConstraints(PassRefPtr<MediaConstraints> constraints) { m_constraints = constraints; }
MediaConstraints* constraints() { return m_constraints.get(); }
@@ -105,7 +105,7 @@ private:
Vector<Observer*> m_observers;
Mutex m_audioConsumersLock;
Vector<RefPtr<AudioDestinationConsumer> > m_audioConsumers;
- OwnPtr<ExtraData> m_extraData;
+ RefPtr<ExtraData> m_extraData;
abarth-chromium 2014/01/10 15:41:18 I don't understand why this need to be ref counted
Tommy Widenflycht 2014/01/13 13:08:40 Doh, neither do I. I was just making sure all of "
RefPtr<MediaConstraints> m_constraints;
};
« no previous file with comments | « Source/platform/exported/WebMediaStreamSource.cpp ('k') | public/platform/WebMediaStreamTrack.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698