Adding owner access from WebMediaStreamTrack::ExtraData

Source/platform/mediastream/MediaStreamSource.h

 /*
  * Copyright (C) 2011 Ericsson AB. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 34 matching lines @@
 namespace WebCore {
 
 class PLATFORM_EXPORT MediaStreamSource : public RefCounted<MediaStreamSource> {
 public:
     class Observer {
     public:
         virtual ~Observer() { }
         virtual void sourceChangedState() = 0;
     };
 
-    class ExtraData {
+    class ExtraData  : public RefCounted<ExtraData> {
     public:
         virtual ~ExtraData() { }
     };
 
     enum Type {
         TypeAudio,
         TypeVideo
     };
 
     enum ReadyState {
         ReadyStateLive = 0,
         ReadyStateMuted = 1,
         ReadyStateEnded = 2
     };
 
     static PassRefPtr<MediaStreamSource> create(const String& id, Type, const String& name, ReadyState = ReadyStateLive, bool requiresConsumer = false);
 
     const String& id() const { return m_id; }
     Type type() const { return m_type; }
     const String& name() const { return m_name; }
 
     void setReadyState(ReadyState);
     ReadyState readyState() const { return m_readyState; }
 
     void addObserver(Observer*);
     void removeObserver(Observer*);
 
     ExtraData* extraData() const { return m_extraData.get(); }
-    void setExtraData(ExtraData* extraData) { m_extraData = adoptPtr(extraData); }
+    void setExtraData(PassRefPtr<ExtraData> extraData) { m_extraData = extraData; }
 
     void setConstraints(PassRefPtr<MediaConstraints> constraints) { m_constraints = constraints; }
     MediaConstraints* constraints() { return m_constraints.get(); }
 
     void setAudioFormat(size_t numberOfChannels, float sampleRate);
     void consumeAudio(AudioBus*, size_t numberOfFrames);
 
     bool requiresAudioConsumer() const { return m_requiresConsumer; }
     void addAudioConsumer(PassRefPtr<AudioDestinationConsumer>);
     bool removeAudioConsumer(AudioDestinationConsumer*);
     const Vector<RefPtr<AudioDestinationConsumer> >& audioConsumers() { return m_audioConsumers; }
 
 private:
     MediaStreamSource(const String& id, Type, const String& name, ReadyState, bool requiresConsumer);
 
     String m_id;
     Type m_type;
     String m_name;
     ReadyState m_readyState;
     bool m_requiresConsumer;
     Vector<Observer*> m_observers;
     Mutex m_audioConsumersLock;
     Vector<RefPtr<AudioDestinationConsumer> > m_audioConsumers;
-    OwnPtr<ExtraData> m_extraData;
+    RefPtr<ExtraData> m_extraData;

[abarth-chromium, 2014/01/10 15:41:18]

I don't understand why this need to be ref counted.  What other object holds a
reference to this object?

[Tommy Widenflycht, 2014/01/13 13:08:40]

Doh, neither do I. I was just making sure all of "my" ExtraData code was the
same when all of them should be changed to OwnPtr instead. Will do that in an
follow-up CL instead.

     RefPtr<MediaConstraints> m_constraints;
 };
 
 typedef Vector<RefPtr<MediaStreamSource> > MediaStreamSourceVector;
 
 } // namespace WebCore
 
 #endif // MediaStreamSource_h