Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 133733004: Adding owner access from WebMediaStreamTrack::ExtraData (Closed)

Created:
6 years, 11 months ago by Tommy Widenflycht
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, philipj_slow, dglazkov+blink, abarth-chromium, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org
Visibility:
Public.

Description

Adding owner access from WebMediaStreamTrack::ExtraData Like WebMediaStreamSource having access to the owner of the ExtraData object simplifies the chromium code significantly. Also taking the opportunity to clean up the ExtraData code in MediaStreamSource after the last of the non-standard code added for WebAudio has been refactored away. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165054

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed MediaStreamSource changes #

Patch Set 3 : Fixed win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M Source/core/platform/chromium/support/WebMediaStreamTrack.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M public/platform/WebMediaStreamTrack.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tommy Widenflycht
6 years, 11 months ago (2014-01-10 14:10:41 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/133733004/diff/1/Source/platform/mediastream/MediaStreamSource.h File Source/platform/mediastream/MediaStreamSource.h (right): https://codereview.chromium.org/133733004/diff/1/Source/platform/mediastream/MediaStreamSource.h#newcode108 Source/platform/mediastream/MediaStreamSource.h:108: RefPtr<ExtraData> m_extraData; I don't understand why this need ...
6 years, 11 months ago (2014-01-10 15:41:18 UTC) #2
Tommy Widenflycht
https://codereview.chromium.org/133733004/diff/1/Source/platform/mediastream/MediaStreamSource.h File Source/platform/mediastream/MediaStreamSource.h (right): https://codereview.chromium.org/133733004/diff/1/Source/platform/mediastream/MediaStreamSource.h#newcode108 Source/platform/mediastream/MediaStreamSource.h:108: RefPtr<ExtraData> m_extraData; On 2014/01/10 15:41:18, abarth wrote: > I ...
6 years, 11 months ago (2014-01-13 13:08:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/133733004/110001
6 years, 11 months ago (2014-01-14 09:13:25 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 10:37:45 UTC) #5
Message was sent while issue was closed.
Change committed as 165054

Powered by Google App Engine
This is Rietveld 408576698