win: Fix OpenProcess(PROCESS_ALL_ACCESS, ...) on XP

util/win/exception_handler_server.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/win/exception_handler_server.h"
 
 #include <string.h>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "minidump/minidump_file_writer.h"
 #include "snapshot/crashpad_info_client_options.h"
 #include "snapshot/win/process_snapshot_win.h"
 #include "util/file/file_writer.h"
 #include "util/misc/tri_state.h"
 #include "util/misc/uuid.h"
 #include "util/win/registration_protocol_win.h"
+#include "util/win/xp_compat.h"
 
 namespace crashpad {
 
 namespace {
 
 decltype(GetNamedPipeClientProcessId)* GetNamedPipeClientProcessIdFunction() {
   static decltype(GetNamedPipeClientProcessId)* func =
       reinterpret_cast<decltype(GetNamedPipeClientProcessId)*>(GetProcAddress(
           GetModuleHandle(L"kernel32.dll"), "GetNamedPipeClientProcessId"));
   return func;
@@ skipping 295 matching lines @@
       return false;
     }
   }
 
   // We attempt to open the process as us. This is the main case that should
   // almost always succeed as the server will generally be more privileged. If
   // we're running as a different user, it may be that we will fail to open
   // the process, but the client will be able to, so we make a second attempt
   // having impersonated the client.
   HANDLE client_process = OpenProcess(
-      PROCESS_ALL_ACCESS, false, message.registration.client_process_id);
+      kXPProcessAllAccess, false, message.registration.client_process_id);
   if (!client_process) {
     if (!ImpersonateNamedPipeClient(service_context.pipe())) {
       PLOG(ERROR) << "ImpersonateNamedPipeClient";
       return false;
     }
     HANDLE client_process = OpenProcess(
-        PROCESS_ALL_ACCESS, false, message.registration.client_process_id);
+        kXPProcessAllAccess, false, message.registration.client_process_id);
     PCHECK(RevertToSelf());
     if (!client_process) {
       LOG(ERROR) << "failed to open " << message.registration.client_process_id;
       return false;
     }
   }
 
   internal::ClientData* client;
   {
     base::AutoLock lock(*service_context.clients_lock());
@@ skipping 56 matching lines @@
 void __stdcall ExceptionHandlerServer::OnProcessEnd(void* ctx, BOOLEAN) {
   // This function is executed on the thread pool.
   internal::ClientData* client = reinterpret_cast<internal::ClientData*>(ctx);
   base::AutoLock lock(*client->lock());
 
   // Post back to the main thread to have it delete this client record.
   PostQueuedCompletionStatus(client->port(), 0, ULONG_PTR(client), nullptr);
 }
 
 }  // namespace crashpad