CHECK that URLRequestJobs are not orphaned while blocked by extensions.

CHECK that URLRequestJobs are not orphaned while blocked by extensions.

This is to help debug https://crbug.com/289715 and try to get a stack trace
earlier.

BUG=289715
Committed: https://crrev.com/a3ef438321e5f7f5167909b2b4b16dbd6593abb8
Cr-Commit-Position: refs/heads/master@{#348745}

[davidben, 2015-09-11 21:33:57]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[davidben, 2015-09-11 21:33:57]

SO MUCH GLUE. I think this is what you suggested.

It may also be worth DCHECK'ing or CHECK'ing at URLRequest entry points that
various functions aren't called while we're waiting on something. That we could
even keep in there long-term.

[mmenke, 2015-09-14 15:18:27]

https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
extensions/browser/api/web_request/web_request_api.cc:1237: CHECK_EQ(0u,
blocked_requests_.count(request->identifier()));
Maybe toss the URL on the stack?

One of the possibilities is that this is an issue with either magic
URLRequestJob subclasses doing stuff when they shouldn't be, or magic
URLRequestJobFactory/Interceptor classes.  The URL may be able to point at one
of those.

[davidben, 2015-09-14 19:55:55]

https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
extensions/browser/api/web_request/web_request_api.cc:1237: CHECK_EQ(0u,
blocked_requests_.count(request->identifier()));
On 2015/09/14 15:18:27, mmenke wrote:
> Maybe toss the URL on the stack?
> 
> One of the possibilities is that this is an issue with either magic
> URLRequestJob subclasses doing stuff when they shouldn't be, or magic
> URLRequestJobFactory/Interceptor classes.  The URL may be able to point at one
> of those.

Done.

[mmenke, 2015-09-14 20:04:40]

On 2015/09/14 19:55:55, David Benjamin wrote:
>
https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
> File extensions/browser/api/web_request/web_request_api.cc (right):
> 
>
https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
> extensions/browser/api/web_request/web_request_api.cc:1237: CHECK_EQ(0u,
> blocked_requests_.count(request->identifier()));
> On 2015/09/14 15:18:27, mmenke wrote:
> > Maybe toss the URL on the stack?
> > 
> > One of the possibilities is that this is an issue with either magic
> > URLRequestJob subclasses doing stuff when they shouldn't be, or magic
> > URLRequestJobFactory/Interceptor classes.  The URL may be able to point at
one
> > of those.
> 
> Done.

LGTM

[mmenke, 2015-09-14 20:05:59]

On 2015/09/14 20:04:40, mmenke wrote:
> On 2015/09/14 19:55:55, David Benjamin wrote:
> >
>
https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
> > File extensions/browser/api/web_request/web_request_api.cc (right):
> > 
> >
>
https://codereview.chromium.org/1337113004/diff/1/extensions/browser/api/web_...
> > extensions/browser/api/web_request/web_request_api.cc:1237: CHECK_EQ(0u,
> > blocked_requests_.count(request->identifier()));
> > On 2015/09/14 15:18:27, mmenke wrote:
> > > Maybe toss the URL on the stack?
> > > 
> > > One of the possibilities is that this is an issue with either magic
> > > URLRequestJob subclasses doing stuff when they shouldn't be, or magic
> > > URLRequestJobFactory/Interceptor classes.  The URL may be able to point at
> one
> > > of those.
> > 
> > Done.
> 
> LGTM

And thanks for doing this - been on my TODO list, but have a backlog on
in-progress CLs that I want to draw down on, first.

[davidben, 2015-09-14 20:18:48]

davidben@chromium.org changed reviewers:
+ kalman@chromium.org

[davidben, 2015-09-14 20:18:49]

+kalman for extensions/

[not at google - send to devlin, 2015-09-14 22:23:46]

lgtm

[davidben, 2015-09-14 22:24:05]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2015-09-14 22:24:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1337113004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1337113004/20001

[commit-bot: I haz the power, 2015-09-14 22:36:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-14 22:37:52]

Patchset 2 (id:??) landed as
https://crrev.com/a3ef438321e5f7f5167909b2b4b16dbd6593abb8
Cr-Commit-Position: refs/heads/master@{#348745}

[commit-bot: I haz the power, 2015-09-23 12:38:15]

Patchset 2 (id:??) landed as
https://crrev.com/a3ef438321e5f7f5167909b2b4b16dbd6593abb8
Cr-Commit-Position: refs/heads/master@{#348745}

[davidben, 2015-11-19 05:37:51]

Just was reminded this existed. Did we gather the data we needed here?

[mmenke, 2015-11-19 05:39:22]

On 2015/11/19 05:37:51, davidben (slow) wrote:
> Just was reminded this existed. Did we gather the data we needed here?

This turned out to be due to the incorrect cancellation on suspend thing, didn't
it?

[davidben, 2015-11-19 17:03:59]

On 2015/11/19 05:39:22, mmenke wrote:
> On 2015/11/19 05:37:51, davidben (slow) wrote:
> > Just was reminded this existed. Did we gather the data we needed here?
> 
> This turned out to be due to the incorrect cancellation on suspend thing,
didn't
> it?

It did? I wasn't paying enough attention. I'll go revert then.

[davidben, 2015-11-19 17:04:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1465503002/ by davidben@chromium.org.

The reason for reverting is: https://crbug.com/289715 is resolved..