Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: net/base/network_delegate.h

Issue 1337113004: CHECK that URLRequestJobs are not orphaned while blocked by extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mmenke comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/layered_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index 715d894371c57a6ea668c29583d7815b031d8354..3a29e26c9f7695a2b7a83fe59bb73f695c6ebf97 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -91,6 +91,7 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
int64_t bytes_received);
void NotifyCompleted(URLRequest* request, bool started);
void NotifyURLRequestDestroyed(URLRequest* request);
+ void NotifyURLRequestJobOrphaned(URLRequest* request);
void NotifyPACScriptError(int line_number, const base::string16& error);
AuthRequiredResponse NotifyAuthRequired(URLRequest* request,
const AuthChallengeInfo& auth_info,
@@ -222,6 +223,13 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
// a virtual method call.
virtual void OnURLRequestDestroyed(URLRequest* request) = 0;
+ // Called when the current job for |request| is orphaned. This is a temporary
+ // callback to diagnose https://crbug.com/289715 and may not be used for other
+ // purposes. Note that it may be called after OnURLRequestDestroyed.
+ //
+ // TODO(davidben): Remove this once data has been gathered.
+ virtual void OnURLRequestJobOrphaned(URLRequest* request) = 0;
+
// Corresponds to ProxyResolverJSBindings::OnError.
virtual void OnPACScriptError(int line_number,
const base::string16& error) = 0;
« no previous file with comments | « net/base/layered_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698