Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 130193003: Make the second argument to Element.setAttribute non-optional (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Make the second argument to Element.setAttribute non-optional This change broke Twitter the first time: http://crbug.com/330261 Twitter was fixed on Dec 20, 2013, so it should be safe to try again. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M LayoutTests/fast/dom/Element/missing-arguments.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/missing-arguments-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-type-change-focusout.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-speech-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/images/style-access-during-imageChanged-style-freeze.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/speech/bubble-position.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-14 02:26:17 UTC) #1
tkent
lgtm
6 years, 11 months ago (2014-01-14 03:23:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/130193003/1
6 years, 11 months ago (2014-01-14 03:23:47 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 04:58:42 UTC) #4
Message was sent while issue was closed.
Change committed as 165028

Powered by Google App Engine
This is Rietveld 408576698