Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1336763005: Document weak pointer factory constructor requirement. (Closed)

Created:
5 years, 3 months ago by scheib
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document weak pointer factory constructor requirement. Committed: https://crrev.com/d5144064af15ce8e24589891c326400a43c27ce0 Cr-Commit-Position: refs/heads/master@{#348966}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/memory/weak_ptr.h View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
scheib
5 years, 3 months ago (2015-09-11 18:29:48 UTC) #2
Nico
lgtm, but: https://codereview.chromium.org/1336763005/diff/1/base/memory/weak_ptr.h File base/memory/weak_ptr.h (right): https://codereview.chromium.org/1336763005/diff/1/base/memory/weak_ptr.h#newcode19 base/memory/weak_ptr.h:19: // Controller() : weak_factory_(this) {} It's not ...
5 years, 3 months ago (2015-09-11 18:41:40 UTC) #3
scheib
https://codereview.chromium.org/1336763005/diff/1/base/memory/weak_ptr.h File base/memory/weak_ptr.h (right): https://codereview.chromium.org/1336763005/diff/1/base/memory/weak_ptr.h#newcode19 base/memory/weak_ptr.h:19: // Controller() : weak_factory_(this) {} On 2015/09/11 18:41:39, Nico ...
5 years, 3 months ago (2015-09-11 19:40:29 UTC) #4
Nico
(wanna cq this?)
5 years, 3 months ago (2015-09-15 02:46:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763005/1
5 years, 3 months ago (2015-09-15 17:31:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 19:53:24 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5144064af15ce8e24589891c326400a43c27ce0 Cr-Commit-Position: refs/heads/master@{#348966}
5 years, 3 months ago (2015-09-15 19:54:04 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:48:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5144064af15ce8e24589891c326400a43c27ce0
Cr-Commit-Position: refs/heads/master@{#348966}

Powered by Google App Engine
This is Rietveld 408576698