Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 1336613002: Stop waiting for service isolate before starting first DartApp (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Stop waiting for service isolate before starting first DartApp Fixes #405 R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d3af0cf4e542d6fb2643906c36e561e03d0d122a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M mojo/dart/embedder/dart_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 3 months ago (2015-09-10 17:05:28 UTC) #2
kulakowski
Tony's out, lgtm though
5 years, 3 months ago (2015-09-10 23:05:50 UTC) #4
qsr
On 2015/09/10 23:05:50, kulakowski wrote: > Tony's out, lgtm though Do you have numbers for ...
5 years, 3 months ago (2015-09-11 07:26:44 UTC) #5
Cutch
5 years, 3 months ago (2015-09-11 14:05:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d3af0cf4e542d6fb2643906c36e561e03d0d122a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698