mojo/dart/embedder/dart_controller.cc - Issue 1336613002: Stop waiting for service isolate before starting first DartApp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/embedder/dart_controller.cc

Issue 1336613002: Stop waiting for service isolate before starting first DartApp (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/embedder/dart_controller.cc

diff --git a/mojo/dart/embedder/dart_controller.cc b/mojo/dart/embedder/dart_controller.cc

index ad86db99421a20403f9bbcaea281505910adf0fa..985f75282d4e61088eb07925859d972b6fa27497 100644

--- a/mojo/dart/embedder/dart_controller.cc

+++ b/mojo/dart/embedder/dart_controller.cc

@@ -690,8 +690,6 @@ bool DartController::Initialize(

}

bool DartController::RunDartScript(const DartControllerConfig& config) {

- BlockForServiceIsolate();

- CHECK(service_isolate_running_);

const bool strict = strict_compilation_ || config.strict_compilation;

Dart_Isolate isolate = CreateIsolateHelper(config.application_data,

strict,

« no previous file with comments | « no previous file | no next file » | no next file with comments »