Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1336603002: Hide existing StrictMode violations. (Closed)

Created:
5 years, 3 months ago by Peter Wen
Modified:
5 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Hide existing StrictMode violations. While we work on to resolve these known StrictMode violations, it's a poor experience for dogfooders to see these every time they are triggered. It is still important for developers and dogfooders to see and report newly introduced violations with the StrictMode red border flash. BUG=508615, 525781, 525785, 527415, 527429 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1334533004 Cr-Commit-Position: refs/heads/master@{#348147} (cherry picked from commit b6f61334631ab1ca930b18e1cbb26d6bb7b92dc7) TBR=yfriedman@chromium.org

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
Peter Wen
Trying out TBR for merge. :)
5 years, 3 months ago (2015-09-10 16:38:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336603002/1
5 years, 3 months ago (2015-09-10 16:39:35 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-10 16:39:36 UTC) #5
Peter Wen
Aww, I guess I need to become a committer first. :)
5 years, 3 months ago (2015-09-10 16:40:35 UTC) #6
Yaron
On 2015/09/10 16:40:35, Peter Wen wrote: > Aww, I guess I need to become a ...
5 years, 3 months ago (2015-09-10 16:41:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336603002/1
5 years, 3 months ago (2015-09-10 16:43:23 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 16:45:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698