Hide existing StrictMode violations.

Hide existing StrictMode violations.

While we work on to resolve these known StrictMode
violations, it's a poor experience for dogfooders to see
these every time they are triggered. It is still
important for developers and dogfooders to see and report
newly introduced violations with the StrictMode red border
flash.

BUG=508615, 525781, 525785, 527415, 527429
Committed: https://crrev.com/b6f61334631ab1ca930b18e1cbb26d6bb7b92dc7
Cr-Commit-Position: refs/heads/master@{#348147}

[Peter Wen, 2015-09-09 20:09:50]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2015-09-09 20:09:50]

Hi Dan,

Recently there have been a lot more bugs filed by dogfooders due to existing
StrictMode issues. This CL hides all the known ones while I work on resolving
them.

In the future I'd like to hide the StrictMode violation as soon as it's found
and create a bug to track fixing it so all our effort goes into looking for new
violations.

Thanks,

Peter

[gone, 2015-09-09 20:18:24]

lgtm % comments

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java:58:
byte[] goodMac;
explicitly set this to null for sanity's sake.  also probably FindBugs' sake.

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java:80:
final CrashFileManager crashFileManager;
ditto on setting this to null explicitly

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:255:
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
I wonder if it's possible to shrink the size of this try/finally block.  Is it
only the the canResolveActivity call that causes the StrictMode violation?

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:106:
File webappBaseDirectory;
explicitly set to null

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:147:
// Delete all webapp directories in the main directory.
nit: move comment above String

[Peter Wen, 2015-09-09 20:26:24]

Thanks for the quick review! :)

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java:58:
byte[] goodMac;
On 2015/09/09 20:18:23, dfalcantara wrote:
> explicitly set this to null for sanity's sake.  also probably FindBugs' sake.

Done.

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java:80:
final CrashFileManager crashFileManager;
On 2015/09/09 20:18:24, dfalcantara wrote:
> ditto on setting this to null explicitly

Done. Since it's final had to move everything into try block. :)

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:255:
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
On 2015/09/09 20:18:24, dfalcantara wrote:
> I wonder if it's possible to shrink the size of this try/finally block.  Is it
> only the the canResolveActivity call that causes the StrictMode violation?

Done.

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java
(right):

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:106:
File webappBaseDirectory;
On 2015/09/09 20:18:24, dfalcantara wrote:
> explicitly set to null

Done.

https://codereview.chromium.org/1334533004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java:147:
// Delete all webapp directories in the main directory.
On 2015/09/09 20:18:24, dfalcantara wrote:
> nit: move comment above String

Done.

[Peter Wen, 2015-09-09 20:29:01]

wnwen@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Peter Wen, 2015-09-09 20:29:02]

+yfriedman for base/android.

[Yaron, 2015-09-09 22:53:35]

On 2015/09/09 20:29:02, Peter Wen wrote:
> +yfriedman for base/android.

lgtm

[Peter Wen, 2015-09-10 13:53:50]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2015-09-10 13:53:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1334533004/#ps40001
(title: "Fixes per review.")

[commit-bot: I haz the power, 2015-09-10 13:53:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334533004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334533004/40001

[commit-bot: I haz the power, 2015-09-10 13:58:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-10 13:59:35]

Patchset 3 (id:??) landed as
https://crrev.com/b6f61334631ab1ca930b18e1cbb26d6bb7b92dc7
Cr-Commit-Position: refs/heads/master@{#348147}

[commit-bot: I haz the power, 2015-09-23 12:10:18]

Patchset 3 (id:??) landed as
https://crrev.com/b6f61334631ab1ca930b18e1cbb26d6bb7b92dc7
Cr-Commit-Position: refs/heads/master@{#348147}