impl/memory/datastore_index_test.go - Issue 1336443003: Implement projection queries correctly.

Unified Diff: impl/memory/datastore_index_test.go

Issue 1336443003: Implement projection queries correctly. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: impl/memory/datastore_index_test.go

diff --git a/impl/memory/datastore_index_test.go b/impl/memory/datastore_index_test.go

index e54922d62404eb3dfae3dbd28669460fb1f68869..e025de3000f2978b5430da4bb4d130bb94aa6e9c 100644

--- a/impl/memory/datastore_index_test.go

+++ b/impl/memory/datastore_index_test.go

@@ -88,6 +88,7 @@ func TestCollated(t *testing.T) {

var rgenComplexTime = time.Date(

1986, time.October, 26, 1, 20, 00, 00, time.UTC)

var rgenComplexKey = key("kind", "id")

+var rgenComplexTimeIdx = prop(rgenComplexTime).ForIndex()

iannucci 2015/09/10 03:56:58 this is actually a Property of type PTInt now.

var rowGenTestCases = []struct {

name string

@@ -163,7 +164,7 @@ var rowGenTestCases = []struct {

"yerp": {prop("hat"), prop(73.9)},

"wat": {

prop(rgenComplexTime),

- prop(ds.ByteString("value")),

+ prop([]byte("value")),

prop(rgenComplexKey)},

"spaz": {prop(nil), prop(false), prop(true)},

@@ -179,22 +180,22 @@ var rowGenTestCases = []struct {

cat(prop("hat"), icat(prop(rgenComplexKey)), prop(nil), prop(fakeKey)),

cat(prop("hat"), icat(prop(rgenComplexKey)), prop(false), prop(fakeKey)),

cat(prop("hat"), icat(prop(rgenComplexKey)), prop(true), prop(fakeKey)),

- cat(prop("hat"), icat(prop(ds.ByteString("value"))), prop(nil), prop(fakeKey)),

- cat(prop("hat"), icat(prop(ds.ByteString("value"))), prop(false), prop(fakeKey)),

- cat(prop("hat"), icat(prop(ds.ByteString("value"))), prop(true), prop(fakeKey)),

- cat(prop("hat"), icat(prop(rgenComplexTime)), prop(nil), prop(fakeKey)),

- cat(prop("hat"), icat(prop(rgenComplexTime)), prop(false), prop(fakeKey)),

- cat(prop("hat"), icat(prop(rgenComplexTime)), prop(true), prop(fakeKey)),

+ cat(prop("hat"), icat(prop("value")), prop(nil), prop(fakeKey)),

+ cat(prop("hat"), icat(prop("value")), prop(false), prop(fakeKey)),

+ cat(prop("hat"), icat(prop("value")), prop(true), prop(fakeKey)),

iannucci 2015/09/10 03:56:58 you can see that []byte and string are no longer d

+ cat(prop("hat"), icat(rgenComplexTimeIdx), prop(nil), prop(fakeKey)),

+ cat(prop("hat"), icat(rgenComplexTimeIdx), prop(false), prop(fakeKey)),

+ cat(prop("hat"), icat(rgenComplexTimeIdx), prop(true), prop(fakeKey)),

cat(prop(73.9), icat(prop(rgenComplexKey)), prop(nil), prop(fakeKey)),

cat(prop(73.9), icat(prop(rgenComplexKey)), prop(false), prop(fakeKey)),

cat(prop(73.9), icat(prop(rgenComplexKey)), prop(true), prop(fakeKey)),

- cat(prop(73.9), icat(prop(ds.ByteString("value"))), prop(nil), prop(fakeKey)),

- cat(prop(73.9), icat(prop(ds.ByteString("value"))), prop(false), prop(fakeKey)),

- cat(prop(73.9), icat(prop(ds.ByteString("value"))), prop(true), prop(fakeKey)),

- cat(prop(73.9), icat(prop(rgenComplexTime)), prop(nil), prop(fakeKey)),

- cat(prop(73.9), icat(prop(rgenComplexTime)), prop(false), prop(fakeKey)),

- cat(prop(73.9), icat(prop(rgenComplexTime)), prop(true), prop(fakeKey)),

+ cat(prop(73.9), icat(prop("value")), prop(nil), prop(fakeKey)),

+ cat(prop(73.9), icat(prop("value")), prop(false), prop(fakeKey)),

+ cat(prop(73.9), icat(prop("value")), prop(true), prop(fakeKey)),

+ cat(prop(73.9), icat(rgenComplexTimeIdx), prop(nil), prop(fakeKey)),

+ cat(prop(73.9), icat(rgenComplexTimeIdx), prop(false), prop(fakeKey)),

+ cat(prop(73.9), icat(rgenComplexTimeIdx), prop(true), prop(fakeKey)),

« impl/memory/datastore_index.go ('K') | « impl/memory/datastore_index.go ('k') | impl/memory/datastore_query_execution_test.go » ('j') | impl/memory/datastore_query_test.go » ('J')