Implement projection queries correctly.

impl/memory/datastore_index_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package memory
 
 import (
         "sort"
         "testing"
         "time"
@@ skipping 70 matching lines @@
                                         So(idxs[4].String(), ShouldEqual, "B:knd/-wat")
                                 })
                         })
                 })
         })
 }
 
 var rgenComplexTime = time.Date(
         1986, time.October, 26, 1, 20, 00, 00, time.UTC)
 var rgenComplexKey = key("kind", "id")
+var rgenComplexTimeIdx = prop(rgenComplexTime).ForIndex()

[iannucci, 2015/09/10 03:56:58]

this is actually a Property of type PTInt now.

 
 var rowGenTestCases = []struct {
         name        string
         pmap        ds.PropertyMap
         withBuiltin bool
         idxs        []*ds.IndexDefinition
 
         // These are checked in TestIndexRowGen. nil to skip test case.
         expected []serializedPvals
 
@@ skipping 55 matching lines @@
                         },
                 },
         },
 
         {
                 name: "complex",
                 pmap: ds.PropertyMap{
                         "yerp": {prop("hat"), prop(73.9)},
                         "wat": {
                                 prop(rgenComplexTime),
-                                prop(ds.ByteString("value")),
+                                prop([]byte("value")),
                                 prop(rgenComplexKey)},
                         "spaz": {prop(nil), prop(false), prop(true)},
                 },
                 idxs: []*ds.IndexDefinition{
                         indx("knd", "-wat", "nerd", "spaz"), // doesn't match, so empty
                         indx("knd", "yerp", "-wat", "spaz"),
                 },
                 expected: []serializedPvals{
                         {}, // C:knd/-wat/nerd/spaz, no match
                         { // C:knd/yerp/-wat/spaz
                                 // thank goodness the binary serialization only happens 1/val in the
                                 // real code :).
                                 cat(prop("hat"), icat(prop(rgenComplexKey)), prop(nil), prop(fakeKey)),
                                 cat(prop("hat"), icat(prop(rgenComplexKey)), prop(false), prop(fakeKey)),
                                 cat(prop("hat"), icat(prop(rgenComplexKey)), prop(true), prop(fakeKey)),
-                                cat(prop("hat"), icat(prop(ds.ByteString("value"))), prop(nil), prop(fakeKey)),
-                                cat(prop("hat"), icat(prop(ds.ByteString("value"))), prop(false), prop(fakeKey)),
-                                cat(prop("hat"), icat(prop(ds.ByteString("value"))), prop(true), prop(fakeKey)),
-                                cat(prop("hat"), icat(prop(rgenComplexTime)), prop(nil), prop(fakeKey)),
-                                cat(prop("hat"), icat(prop(rgenComplexTime)), prop(false), prop(fakeKey)),
-                                cat(prop("hat"), icat(prop(rgenComplexTime)), prop(true), prop(fakeKey)),
+                                cat(prop("hat"), icat(prop("value")), prop(nil), prop(fakeKey)),
+                                cat(prop("hat"), icat(prop("value")), prop(false), prop(fakeKey)),
+                                cat(prop("hat"), icat(prop("value")), prop(true), prop(fakeKey)),

[iannucci, 2015/09/10 03:56:58]

you can see that []byte and string are no longer distinguished in the index.
This is how it works for realsies.

+                                cat(prop("hat"), icat(rgenComplexTimeIdx), prop(nil), prop(fakeKey)),
+                                cat(prop("hat"), icat(rgenComplexTimeIdx), prop(false), prop(fakeKey)),
+                                cat(prop("hat"), icat(rgenComplexTimeIdx), prop(true), prop(fakeKey)),
 
                                 cat(prop(73.9), icat(prop(rgenComplexKey)), prop(nil), prop(fakeKey)),
                                 cat(prop(73.9), icat(prop(rgenComplexKey)), prop(false), prop(fakeKey)),
                                 cat(prop(73.9), icat(prop(rgenComplexKey)), prop(true), prop(fakeKey)),
-                                cat(prop(73.9), icat(prop(ds.ByteString("value"))), prop(nil), prop(fakeKey)),
-                                cat(prop(73.9), icat(prop(ds.ByteString("value"))), prop(false), prop(fakeKey)),
-                                cat(prop(73.9), icat(prop(ds.ByteString("value"))), prop(true), prop(fakeKey)),
-                                cat(prop(73.9), icat(prop(rgenComplexTime)), prop(nil), prop(fakeKey)),
-                                cat(prop(73.9), icat(prop(rgenComplexTime)), prop(false), prop(fakeKey)),
-                                cat(prop(73.9), icat(prop(rgenComplexTime)), prop(true), prop(fakeKey)),
+                                cat(prop(73.9), icat(prop("value")), prop(nil), prop(fakeKey)),
+                                cat(prop(73.9), icat(prop("value")), prop(false), prop(fakeKey)),
+                                cat(prop(73.9), icat(prop("value")), prop(true), prop(fakeKey)),
+                                cat(prop(73.9), icat(rgenComplexTimeIdx), prop(nil), prop(fakeKey)),
+                                cat(prop(73.9), icat(rgenComplexTimeIdx), prop(false), prop(fakeKey)),
+                                cat(prop(73.9), icat(rgenComplexTimeIdx), prop(true), prop(fakeKey)),
                         },
                 },
         },
 
         {
                 name: "ancestor",
                 pmap: ds.PropertyMap{
                         "wat": {prop("sup")},
                 },
                 idxs: []*ds.IndexDefinition{
@@ skipping 195 matching lines @@
                                                 So(data[i], ShouldResemble, itm.Key)
                                                 i++
                                                 return true
                                         })
                                         So(i, ShouldEqual, len(data))
                                 }
                         })
                 }
         })
 }