Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1336363002: Add DevTools method for cross-process memory notification suppressing (Closed)

Created:
5 years, 3 months ago by petrcermak
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DevTools method for cross-process memory notification suppressing This patch adds Memory.setPressureNotificationsSuppressed method to DevTools API. The underlying IPC architecture was added in https://codereview.chromium.org/1361963002. Proposal: https://goo.gl/cZFdH3 BUG=516776 Committed: https://crrev.com/a954d6b30bffd58a21dfd2d9f850329e126d399c Cr-Commit-Position: refs/heads/master@{#350550}

Patch Set 1 #

Patch Set 2 : Remove asynchronous callback #

Patch Set 3 : Merge patches (after Blink merge) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M content/browser/devtools/browser_devtools_agent_host.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
A content/browser/devtools/protocol/memory_handler.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A content/browser/devtools/protocol/memory_handler.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
petrcermak
Hi, please review this small patch. Thanks, Petr
5 years, 3 months ago (2015-09-17 16:14:49 UTC) #5
pfeldman
lgtm
5 years, 3 months ago (2015-09-17 19:13:25 UTC) #6
petrcermak
https://codereview.chromium.org/1311343007/ and https://codereview.chromium.org/1342833004/ were merged into this patch after the Blink merge. Both patches had ...
5 years, 3 months ago (2015-09-24 13:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336363002/100001
5 years, 3 months ago (2015-09-24 13:31:32 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 3 months ago (2015-09-24 14:46:00 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 14:46:46 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a954d6b30bffd58a21dfd2d9f850329e126d399c
Cr-Commit-Position: refs/heads/master@{#350550}

Powered by Google App Engine
This is Rietveld 408576698