Re-land architecture for cross-process memory notification suppressing

Re-land architecture for cross-process memory notification suppressing

This patch re-lands https://codereview.chromium.org/1332583002/ after
it was reverted in https://codereview.chromium.org/1359873002/ because
it was causing failures on the Cast Linux buildbot.

The failures were caused by std::set operations being carried out
inside DCHECK macros, which are not evaluated on release builds:

  DCHECK(memory_message_filters_.insert(filter).second);

This patch moves the std::set operations outside the macros so that
they would always be evaluated:

  const bool success = memory_message_filters_.insert(filter).second;
  DCHECK(success);

BUG=516776
Committed: https://crrev.com/29bd40509cd5f705d686a97f2c91e3a75501cf2a
Cr-Commit-Position: refs/heads/master@{#350503}

[petrcermak, 2015-09-23 10:13:41]

petrcermak@chromium.org changed reviewers:
+ skyostil@chromium.org

[petrcermak, 2015-09-23 10:13:41]

Hi,

Can you please review this re-land (it's just a tiny fix)?

Thanks,
Petr

[Sami, 2015-09-23 10:29:44]

lgtm to reland.

https://codereview.chromium.org/1361963002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_pressure_controller.cc (right):

https://codereview.chromium.org/1361963002/diff/20001/content/browser/memory/...
content/browser/memory/memory_pressure_controller.cc:25: DCHECK(success);
This might complain about |success| not being used in release builds, but the
bots should tell us if that's a problem.

[petrcermak, 2015-09-23 10:32:37]

Thanks for your comments.

Petr

https://codereview.chromium.org/1361963002/diff/20001/content/browser/memory/...
File content/browser/memory/memory_pressure_controller.cc (right):

https://codereview.chromium.org/1361963002/diff/20001/content/browser/memory/...
content/browser/memory/memory_pressure_controller.cc:25: DCHECK(success);
On 2015/09/23 10:29:44, Sami wrote:
> This might complain about |success| not being used in release builds, but the
> bots should tell us if that's a problem.

This pattern is used in other parts of the codebase and it should be fine
according to
https://code.google.com/p/chromium/codesearch#chromium/src/base/logging.h&l=656.

[petrcermak, 2015-09-23 10:33:10]

petrcermak@chromium.org changed reviewers:
+ nasko@chromium.org

[petrcermak, 2015-09-23 10:33:11]

nasko@: Hi, could I please get an owner stamp for this re-land?

Thanks,
Petr

[nasko, 2015-09-23 13:56:56]

LGTM

[petrcermak, 2015-09-23 18:16:05]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2015-09-23 18:19:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361963002/20001

[commit-bot: I haz the power, 2015-09-23 19:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 19:53:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[petrcermak, 2015-09-24 07:45:28]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2015-09-24 07:45:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361963002/20001

[commit-bot: I haz the power, 2015-09-24 08:29:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 08:29:47]

Patchset 2 (id:??) landed as
https://crrev.com/29bd40509cd5f705d686a97f2c91e3a75501cf2a
Cr-Commit-Position: refs/heads/master@{#350503}

[petrcermak, 2015-09-24 13:18:24]

This patch was merged into https://codereview.chromium.org/1336363002/ after the
Blink merge.

[petrcermak, 2015-09-24 13:19:33]

On 2015/09/24 13:18:24, petrcermak wrote:
> This patch was merged into https://codereview.chromium.org/1336363002/ after
the
> Blink merge.

Sorry, the previous message belonged to a different patch
(https://codereview.chromium.org/1311343007/ and
https://codereview.chromium.org/1342833004/).