Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336233002: Temporarily comment out enqueue_order_set_ DCHECK (Closed)

Created:
5 years, 3 months ago by kinuko
Modified:
5 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily comment out enqueue_order_set_ DCHECK The check makes multiple browser_tests fail on debug build. Rather than disabling each test, let me comment it out for now. BUG=530593 TBR=skyostil@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/d77f8710b1fb8d4e04ea09014893f2102a2f8faf Cr-Commit-Position: refs/heads/master@{#348558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 2 chunks +6 lines, -40 lines 0 comments Download
M components/scheduler/child/task_queue_impl.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336233002/1
5 years, 3 months ago (2015-09-14 04:02:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336233002/1
5 years, 3 months ago (2015-09-14 04:05:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336233002/1
5 years, 3 months ago (2015-09-14 04:46:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 04:46:53 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d77f8710b1fb8d4e04ea09014893f2102a2f8faf Cr-Commit-Position: refs/heads/master@{#348558}
5 years, 3 months ago (2015-09-14 04:47:50 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:29:13 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d77f8710b1fb8d4e04ea09014893f2102a2f8faf
Cr-Commit-Position: refs/heads/master@{#348558}

Powered by Google App Engine
This is Rietveld 408576698