Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: components/scheduler/child/task_queue_impl.h

Issue 1336233002: Temporarily comment out enqueue_order_set_ DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_SCHEDULER_TASK_QUEUE_IMPL_H_ 5 #ifndef CONTENT_RENDERER_SCHEDULER_TASK_QUEUE_IMPL_H_
6 #define CONTENT_RENDERER_SCHEDULER_TASK_QUEUE_IMPL_H_ 6 #define CONTENT_RENDERER_SCHEDULER_TASK_QUEUE_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/pending_task.h" 10 #include "base/pending_task.h"
(...skipping 19 matching lines...) Expand all
30 class SCHEDULER_EXPORT Task : public base::PendingTask { 30 class SCHEDULER_EXPORT Task : public base::PendingTask {
31 public: 31 public:
32 Task(); 32 Task();
33 Task(const tracked_objects::Location& posted_from, 33 Task(const tracked_objects::Location& posted_from,
34 const base::Closure& task, 34 const base::Closure& task,
35 int sequence_number, 35 int sequence_number,
36 bool nestable); 36 bool nestable);
37 37
38 int enqueue_order() const { 38 int enqueue_order() const {
39 #ifndef NDEBUG 39 #ifndef NDEBUG
40 DCHECK(enqueue_order_set_); 40 // Temporarily commenting out this DCHECK for breaking multiple tests:
41 // (crbug.com/530593)
42 // DCHECK(enqueue_order_set_);
41 #endif 43 #endif
42 return enqueue_order_; 44 return enqueue_order_;
43 } 45 }
44 46
45 void set_enqueue_order(int enqueue_order) { 47 void set_enqueue_order(int enqueue_order) {
46 #ifndef NDEBUG 48 #ifndef NDEBUG
47 DCHECK(!enqueue_order_set_); 49 DCHECK(!enqueue_order_set_);
48 enqueue_order_set_ = true; 50 enqueue_order_set_ = true;
49 #endif 51 #endif
50 enqueue_order_ = enqueue_order; 52 enqueue_order_ = enqueue_order;
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 bool should_monitor_quiescence_; 205 bool should_monitor_quiescence_;
204 bool should_notify_observers_; 206 bool should_notify_observers_;
205 207
206 DISALLOW_COPY_AND_ASSIGN(TaskQueueImpl); 208 DISALLOW_COPY_AND_ASSIGN(TaskQueueImpl);
207 }; 209 };
208 210
209 } // namespace internal 211 } // namespace internal
210 } // namespace scheduler 212 } // namespace scheduler
211 213
212 #endif // CONTENT_RENDERER_SCHEDULER_TASK_QUEUE_IMPL_H_ 214 #endif // CONTENT_RENDERER_SCHEDULER_TASK_QUEUE_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698