Implement SimulateMatchingPhase by real calls to PasswordFormManager::FetchMatchingLoginsFromPasswo…

Implement SimulateMatchingPhase by real calls to PasswordFormManager::FetchMatchingLoginsFromPasswordStore

This allows to unfriend PasswordFormManagerTest from PasswordFormManager.

Also separated test TestNewLogin into two tests TestNewLogin and TestAdditionalLogin, because they tested separate things.

BUG=520831
Committed: https://crrev.com/e53294e1c86136d854a4ec355a170ff90aafbe0b
Cr-Commit-Position: refs/heads/master@{#348694}

[lucinka.brozkova, 2015-09-13 10:10:54]

lucinka.brozkova@gmail.com changed reviewers:
+ dvadym@chromium.org

[lucinka.brozkova, 2015-09-13 10:10:54]

Hi Vadym,

Could you please review?

Thank you.

Lucie

[dvadym, 2015-09-14 12:35:04]

Hi Lucinka,

 Thanks for contributing. 
 LGTM % a nit.

Best regards,
Vadym

https://codereview.chromium.org/1336193002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_form_manager_unittest.cc
(right):

https://codereview.chromium.org/1336193002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager_unittest.cc:277:
match->preferred = true;
Just wondering, do we need to set |preferred| to true?

https://codereview.chromium.org/1336193002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager_unittest.cc:278:
ScopedVector<PasswordForm> resultForm;
nit: resultForm -> result_form

[lucinka.brozkova, 2015-09-14 19:26:47]

Hi Vadym,

Thank you for the review.

Comments addressed.

https://codereview.chromium.org/1336193002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_form_manager_unittest.cc
(right):

https://codereview.chromium.org/1336193002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager_unittest.cc:277:
match->preferred = true;
On 2015/09/14 12:35:04, dvadym wrote:
> Just wondering, do we need to set |preferred| to true?
You are right, it doesn't have to be set to true and the behaviour is the same.
Done.

https://codereview.chromium.org/1336193002/diff/20001/components/password_man...
components/password_manager/core/browser/password_form_manager_unittest.cc:278:
ScopedVector<PasswordForm> resultForm;
On 2015/09/14 12:35:04, dvadym wrote:
> nit: resultForm -> result_form

Done.

[lucinka.brozkova, 2015-09-14 19:27:16]

The CQ bit was checked by lucinka.brozkova@gmail.com

[lucinka.brozkova, 2015-09-14 19:27:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dvadym@chromium.org
Link to the patchset: https://codereview.chromium.org/1336193002/#ps40001
(title: "comments addressed")

[commit-bot: I haz the power, 2015-09-14 19:27:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336193002/40001

[commit-bot: I haz the power, 2015-09-14 20:05:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-14 20:06:05]

Patchset 3 (id:??) landed as
https://crrev.com/e53294e1c86136d854a4ec355a170ff90aafbe0b
Cr-Commit-Position: refs/heads/master@{#348694}

[commit-bot: I haz the power, 2015-09-23 12:36:16]

Patchset 3 (id:??) landed as
https://crrev.com/e53294e1c86136d854a4ec355a170ff90aafbe0b
Cr-Commit-Position: refs/heads/master@{#348694}