components/password_manager/core/browser/password_form_manager.h - Issue 1336193002: Implement SimulateMatchingPhase by real calls to PasswordFormManager::FetchMatchingLoginsFromPasswo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1336193002: Implement SimulateMatchingPhase by real calls to PasswordFormManager::FetchMatchingLoginsFromPasswo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index b020e362626374e448902d2cd84132c69b08868f..c2bed1c8183f9972d0350dbf5d7ee28466abda6c 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -228,8 +228,6 @@ class PasswordFormManager : public PasswordStoreConsumer {

void WipeStoreCopyIfOutdated();

private:

- friend class PasswordFormManagerTest;

// ManagerAction - What does the manager do with this form? Either it

// fills it, or it doesn't. If it doesn't fill it, that's either

// because it has no match, or it is blacklisted, or it is disabled

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »