Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1336123002: Fix spread operator in ArrayLiterals when nested in other literals (Closed)

Created:
5 years, 3 months ago by adamk
Modified:
5 years, 3 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix spread operator in ArrayLiterals when nested in other literals Mark ArrayLiterals utilizing the spread operator as non-simple. This causes them to return false for IsCompileTimeValue, and thus causes spread to work as expected in nested literals. BUG=v8:4417 LOG=y Committed: https://crrev.com/f44efd6b3156a3322cc514b76a67aff447da7e9b Cr-Commit-Position: refs/heads/master@{#30754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/harmony/regress/regress-4417.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 3 months ago (2015-09-11 23:58:32 UTC) #2
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-09-15 15:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336123002/1
5 years, 3 months ago (2015-09-15 16:03:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 16:43:34 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 16:43:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f44efd6b3156a3322cc514b76a67aff447da7e9b
Cr-Commit-Position: refs/heads/master@{#30754}

Powered by Google App Engine
This is Rietveld 408576698