src/ast.cc - Issue 1336123002: Fix spread operator in ArrayLiterals when nested in other literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 1336123002: Fix spread operator in ArrayLiterals when nested in other literals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 1b39e3190aa4021ebc6217b063dc219e9582e9d2..e2d24f9e0c44ae376f85547409bc79d17094b06c 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -556,7 +556,7 @@ void ArrayLiteral::BuildConstantElements(Isolate* isolate) {

Strength::WEAK, INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE);

// Fill in the literals.

- bool is_simple = true;

+ bool is_simple = (first_spread_index_ < 0);

int depth_acc = 1;

bool is_holey = false;

int array_index = 0;

« no previous file with comments | « no previous file | test/mjsunit/harmony/regress/regress-4417.js » ('j') | no next file with comments »