Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1335943002: Avoid warnings in NetworkQualityEstimatorTest.TestCaching (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
bengr, tbansal1
CC:
chromium-reviews, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays), ckulakowski
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid warnings in NetworkQualityEstimatorTest.TestCaching Gets rid of the following compilation errors: ../../net/base/network_quality_estimator_unittest.cc:465:118: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression] ../../net/base/network_quality_estimator_unittest.cc:476:118: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression] Committed: https://crrev.com/906741c85d7e7a5abcef3bedc9b0e31091afd365 Cr-Commit-Position: refs/heads/master@{#348384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M net/base/network_quality_estimator_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
5 years, 3 months ago (2015-09-11 11:32:13 UTC) #2
bengr
lgtm
5 years, 3 months ago (2015-09-11 12:40:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335943002/1
5 years, 3 months ago (2015-09-11 12:57:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 13:02:24 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/906741c85d7e7a5abcef3bedc9b0e31091afd365 Cr-Commit-Position: refs/heads/master@{#348384}
5 years, 3 months ago (2015-09-11 13:03:20 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:21:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/906741c85d7e7a5abcef3bedc9b0e31091afd365
Cr-Commit-Position: refs/heads/master@{#348384}

Powered by Google App Engine
This is Rietveld 408576698