Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: net/base/network_quality_estimator_unittest.cc

Issue 1335943002: Avoid warnings in NetworkQualityEstimatorTest.TestCaching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_quality_estimator_unittest.cc
diff --git a/net/base/network_quality_estimator_unittest.cc b/net/base/network_quality_estimator_unittest.cc
index 6790bb7637b6dae14fff943c90f447bd0a14c3b0..b1ffdebaeb58e378ad6806ba6c2028f26ae2a33a 100644
--- a/net/base/network_quality_estimator_unittest.cc
+++ b/net/base/network_quality_estimator_unittest.cc
@@ -512,7 +512,8 @@ TEST(NetworkQualityEstimatorTest, TestCaching) {
estimator.SimulateNetworkChangeTo(
NetworkChangeNotifier::ConnectionType::CONNECTION_3G, "test-1");
- EXPECT_EQ(++expected_cache_size, estimator.cached_network_qualities_.size());
+ ++expected_cache_size;
+ EXPECT_EQ(expected_cache_size, estimator.cached_network_qualities_.size());
// Entry will be added for (3G, "test1").
// Also, set the network quality for (3G, "test1") so that it is stored in
@@ -523,7 +524,8 @@ TEST(NetworkQualityEstimatorTest, TestCaching) {
NetworkQualityEstimator::Observation(500, base::TimeTicks::Now()));
estimator.SimulateNetworkChangeTo(
NetworkChangeNotifier::ConnectionType::CONNECTION_3G, "test-2");
- EXPECT_EQ(++expected_cache_size, estimator.cached_network_qualities_.size());
+ ++expected_cache_size;
+ EXPECT_EQ(expected_cache_size, estimator.cached_network_qualities_.size());
// Entry will not be added for (3G, "test2").
estimator.SimulateNetworkChangeTo(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698