Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1335633002: Do not look for the slot in the ScopeInfo's global range when it's not necessary. (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not look for the slot in the ScopeInfo's global range when it's not necessary. This fixes the Runtime_DeclareGlobals performance regression caused by a huge number of global var declarations mentioned in chromium:517778. BUG=chromium:517778 LOG=N Committed: https://crrev.com/a1c1e2bd44ca4f5381c47b34be7648e94bf775d7 Cr-Commit-Position: refs/heads/master@{#30679}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -91 lines) Patch
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/contexts.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/debug/debug-frames.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +13 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/scopeinfo.h View 5 chunks +6 lines, -30 lines 0 comments Download
M src/scopeinfo.cc View 1 7 chunks +43 lines, -33 lines 0 comments Download
M src/scopes.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Igor Sheludko
PTAL
5 years, 3 months ago (2015-09-10 12:28:55 UTC) #3
Benedikt Meurer
LGTM. I like it!
5 years, 3 months ago (2015-09-10 12:33:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335633002/20001
5 years, 3 months ago (2015-09-10 12:35:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-10 12:55:01 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 12:55:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1c1e2bd44ca4f5381c47b34be7648e94bf775d7
Cr-Commit-Position: refs/heads/master@{#30679}

Powered by Google App Engine
This is Rietveld 408576698