Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: src/debug/debug-frames.cc

Issue 1335633002: Do not look for the slot in the ScopeInfo's global range when it's not necessary. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Cleanup Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug-frames.h" 5 #include "src/debug/debug-frames.h"
6 6
7 #include "src/frames-inl.h" 7 #include "src/frames-inl.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 target, handle(scope_info->StackLocalName(i), isolate_)) 173 target, handle(scope_info->StackLocalName(i), isolate_))
174 .ToHandleChecked(); 174 .ToHandleChecked();
175 frame_->SetExpression(index, *value); 175 frame_->SetExpression(index, *value);
176 } 176 }
177 } 177 }
178 178
179 179
180 bool FrameInspector::ParameterIsShadowedByContextLocal( 180 bool FrameInspector::ParameterIsShadowedByContextLocal(
181 Handle<ScopeInfo> info, Handle<String> parameter_name) { 181 Handle<ScopeInfo> info, Handle<String> parameter_name) {
182 VariableMode mode; 182 VariableMode mode;
183 VariableLocation location;
184 InitializationFlag init_flag; 183 InitializationFlag init_flag;
185 MaybeAssignedFlag maybe_assigned_flag; 184 MaybeAssignedFlag maybe_assigned_flag;
186 return ScopeInfo::ContextSlotIndex(info, parameter_name, &mode, &location, 185 return ScopeInfo::ContextSlotIndex(info, parameter_name, &mode, &init_flag,
187 &init_flag, &maybe_assigned_flag) != -1; 186 &maybe_assigned_flag) != -1;
188 } 187 }
189 188
190 189
191 SaveContext* DebugFrameHelper::FindSavedContextForFrame( 190 SaveContext* DebugFrameHelper::FindSavedContextForFrame(
192 Isolate* isolate, JavaScriptFrame* frame) { 191 Isolate* isolate, JavaScriptFrame* frame) {
193 SaveContext* save = isolate->save_context(); 192 SaveContext* save = isolate->save_context();
194 while (save != NULL && !save->IsBelowFrame(frame)) { 193 while (save != NULL && !save->IsBelowFrame(frame)) {
195 save = save->prev(); 194 save = save->prev();
196 } 195 }
197 DCHECK(save != NULL); 196 DCHECK(save != NULL);
(...skipping 12 matching lines...) Expand all
210 if (!frames[i].function()->IsSubjectToDebugging()) continue; 209 if (!frames[i].function()->IsSubjectToDebugging()) continue;
211 if (++count == index) return i; 210 if (++count == index) return i;
212 } 211 }
213 } 212 }
214 return -1; 213 return -1;
215 } 214 }
216 215
217 216
218 } // namespace internal 217 } // namespace internal
219 } // namespace v8 218 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug-evaluate.cc ('k') | src/debug/debug-scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698