DescriptionOilpan: The number of normal persistent handles shouldn't be used for estimating heap size
Currently we're estimating the live heap size as follows:
(live heap size) = (current heap size) - ((heap size at last GC) / (# of persistent handles at last GC) * (# of persistent handles collected since last GC))
In this equation, "persistent handles" contains V8 wrappers and normal persistent handles.
This CL drops the normal persistent handles from the "persistent handles".
The reason is that it doesn't make much sense to take into account the number of normal persistent handles
because normal persistent handles can frequently be allocated and deallocated on stack.
Those on-stack persistent handles can even be nullptr. It doesn't make sense to assume that
these persistent handles are holding a substantial amount of memory.
I've sometimes observed that conservative GCs get scheduled a bit too aggressively
because the memory held by the persistent handles is overestimated. This CL fixes the issue.
BUG=474470
Committed: https://crrev.com/2a9913f8f4cd3a9c343fbf0ef074dd466b2b80ca
git-svn-id: svn://svn.chromium.org/blink/trunk@202104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #Patch Set 2 : #
Depends on Patchset: Messages
Total messages: 8 (2 generated)
|