Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1335493003: Oilpan: The number of normal persistent handles shouldn't be used for estimating heap size (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
keishi, Yuta Kitamura
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: The number of normal persistent handles shouldn't be used for estimating heap size Currently we're estimating the live heap size as follows: (live heap size) = (current heap size) - ((heap size at last GC) / (# of persistent handles at last GC) * (# of persistent handles collected since last GC)) In this equation, "persistent handles" contains V8 wrappers and normal persistent handles. This CL drops the normal persistent handles from the "persistent handles". The reason is that it doesn't make much sense to take into account the number of normal persistent handles because normal persistent handles can frequently be allocated and deallocated on stack. Those on-stack persistent handles can even be nullptr. It doesn't make sense to assume that these persistent handles are holding a substantial amount of memory. I've sometimes observed that conservative GCs get scheduled a bit too aggressively because the memory held by the persistent handles is overestimated. This CL fixes the issue. BUG=474470 Committed: https://crrev.com/2a9913f8f4cd3a9c343fbf0ef074dd466b2b80ca git-svn-id: svn://svn.chromium.org/blink/trunk@202104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/platform/heap/Handle.h View 1 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
haraken
PTAL I'll collect full memory numbers on memory.top_7_stress overnight.
5 years, 3 months ago (2015-09-10 13:03:33 UTC) #2
haraken
On 2015/09/10 13:03:33, haraken wrote: > PTAL > > I'll collect full memory numbers on ...
5 years, 3 months ago (2015-09-11 00:17:57 UTC) #3
keishi
LGTM
5 years, 3 months ago (2015-09-11 02:44:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335493003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335493003/20001
5 years, 3 months ago (2015-09-11 03:26:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202104
5 years, 3 months ago (2015-09-11 04:12:50 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:18:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a9913f8f4cd3a9c343fbf0ef074dd466b2b80ca

Powered by Google App Engine
This is Rietveld 408576698