Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1334683002: Oilpan: An Oilpan idle GC should follow a V8 major GC (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, keishi, ulan
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, blink-reviews-bindings_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: An Oilpan idle GC should follow a V8 major GC In bug 530064, V8 contexts remain for a long time because Oilpan's GC isn't scheduled after V8 major GCs. To avoid that from happening, this CL forces an idle GC after a V8 major GC finishes weak processings. This CL won't affect performance of micro-benchmarks, since those benchmarks don't have a chance to schedule idle GCs anyway. BUG=530064 Committed: https://crrev.com/2e1ab18e2db149eb1b529c1cbf69545a4b21f2e5 git-svn-id: svn://svn.chromium.org/blink/trunk@202055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Source/bindings/core/v8/V8GCController.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
haraken
PTAL (ulan: FYI)
5 years, 3 months ago (2015-09-10 12:45:17 UTC) #2
keishi
LGTM https://codereview.chromium.org/1334683002/diff/1/Source/platform/heap/ThreadState.h File Source/platform/heap/ThreadState.h (right): https://codereview.chromium.org/1334683002/diff/1/Source/platform/heap/ThreadState.h#newcode331 Source/platform/heap/ThreadState.h:331: void scheduleV8FollowupGCIfNeeded(bool shouldScheduleIdleGC); nit: maybe enum is better ...
5 years, 3 months ago (2015-09-10 12:53:39 UTC) #3
haraken
https://codereview.chromium.org/1334683002/diff/1/Source/platform/heap/ThreadState.h File Source/platform/heap/ThreadState.h (right): https://codereview.chromium.org/1334683002/diff/1/Source/platform/heap/ThreadState.h#newcode331 Source/platform/heap/ThreadState.h:331: void scheduleV8FollowupGCIfNeeded(bool shouldScheduleIdleGC); On 2015/09/10 12:53:39, keishi wrote: > ...
5 years, 3 months ago (2015-09-10 13:09:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334683002/20001
5 years, 3 months ago (2015-09-10 13:09:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202055
5 years, 3 months ago (2015-09-10 14:48:23 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:10:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e1ab18e2db149eb1b529c1cbf69545a4b21f2e5

Powered by Google App Engine
This is Rietveld 408576698