Disable exit fullscreen animation

Disable exit fullscreen animation since it is not stable
on all versions of OSX.

BUG=526327
Committed: https://crrev.com/b86e5ec19000673ba632555964e1976182415864
Cr-Commit-Position: refs/heads/master@{#348665}

[spqchan1, 2015-09-11 22:26:32]

spqchan@google.com changed reviewers:
+ erikchen@chromium.org

[spqchan1, 2015-09-11 22:27:57]

PTAL

[erikchen, 2015-09-11 22:30:22]

https://codereview.chromium.org/1335333002/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/1335333002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:1080: if
(!enterFullScreen && !base::mac::IsOSYosemite())
This disables the fullscreen animation as well, is that intentional?

Given that there's only 1 OSX version on which the exit transition works (and
there are still some minor problems), perhaps we should just disable this on all
OSX versions until it's working better?

[spqchan1, 2015-09-11 22:34:50]

https://codereview.chromium.org/1335333002/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/1335333002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:1080: if
(!enterFullScreen && !base::mac::IsOSYosemite())
On 2015/09/11 22:30:22, erikchen wrote:
> This disables the fullscreen animation as well, is that intentional?
> 
> Given that there's only 1 OSX version on which the exit transition works (and
> there are still some minor problems), perhaps we should just disable this on
all
> OSX versions until it's working better?

Yes, that was intentional. Sure, that would make sense.

[spqchan1, 2015-09-11 23:14:34]

PTAL

[erikchen, 2015-09-12 01:07:33]

lgtm with nits

https://codereview.chromium.org/1335333002/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/1335333002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:1080: if
(!enterFullScreen && !base::mac::IsOSYosemite())
On 2015/09/11 22:34:50, spqchan1 wrote:
> On 2015/09/11 22:30:22, erikchen wrote:
> > This disables the fullscreen animation as well, is that intentional?
> > 
> > Given that there's only 1 OSX version on which the exit transition works
(and
> > there are still some minor problems), perhaps we should just disable this on
> all
> > OSX versions until it's working better?
> 
> Yes, that was intentional. Sure, that would make sense.

Can you update your comment then, since it implies that you are only disabling
the exit transition?

[spqchan1, 2015-09-14 17:47:45]

spqchan@google.com changed reviewers:
+ rsesek@chromium.org

[spqchan1, 2015-09-14 17:47:46]

+rsesek

PTAL

[Robert Sesek, 2015-09-14 18:00:23]

lgtm

[spqchan1, 2015-09-14 18:01:02]

The CQ bit was checked by spqchan@google.com

[spqchan1, 2015-09-14 18:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1335333002/#ps40001
(title: "Fixed a comment")

[commit-bot: I haz the power, 2015-09-14 18:02:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335333002/40001

[commit-bot: I haz the power, 2015-09-14 18:39:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-14 18:40:45]

Patchset 3 (id:??) landed as
https://crrev.com/b86e5ec19000673ba632555964e1976182415864
Cr-Commit-Position: refs/heads/master@{#348665}

[commit-bot: I haz the power, 2015-09-23 12:34:52]

Patchset 3 (id:??) landed as
https://crrev.com/b86e5ec19000673ba632555964e1976182415864
Cr-Commit-Position: refs/heads/master@{#348665}