Disable exit fullscreen animation

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/mac/bind_objc_block.h"
@@ skipping 1056 matching lines @@
   if (![[self class] systemSettingsRequireMavericksAppKitFullscreenHack])
     return NO;
   if (!enteringAppKitFullscreen_)
     return NO;
   if (enteringAppKitFullscreenOnPrimaryScreen_)
     return NO;
 
   return YES;
 }
 
-- (BOOL)shouldUseCustomAppKitFullscreenTransition {
+- (BOOL)shouldUseCustomAppKitFullscreenTransition:(BOOL)enterFullScreen {
+  // TODO(spqchan): Fix exit fullscreen transition so that it works on other
+  // OSX versions.
+  if (!enterFullScreen && !base::mac::IsOSYosemite())

[erikchen, 2015/09/11 22:30:22]

This disables the fullscreen animation as well, is that intentional?

Given that there's only 1 OSX version on which the exit transition works (and
there are still some minor problems), perhaps we should just disable this on all
OSX versions until it's working better?

[spqchan1, 2015/09/11 22:34:50]

Yes, that was intentional. Sure, that would make sense.

[erikchen, 2015/09/12 01:07:33]

Can you update your comment then, since it implies that you are only disabling
the exit transition?

+    return NO;
+
   if (base::mac::IsOSMountainLionOrEarlier())
     return NO;
 
   NSView* root = [[self.window contentView] superview];
   if (!root.layer)
     return NO;
 
   // AppKit on OSX 10.9 has a bug for applications linked against OSX 10.8 SDK
   // and earlier. Under specific circumstances, it prevents the custom AppKit
   // transition from working well. See http://crbug.com/396980 for more
   // details.
   if ([[self class] systemSettingsRequireMavericksAppKitFullscreenHack] &&
       ![[[self window] screen] isEqual:[[NSScreen screens] objectAtIndex:0]]) {
     return NO;
   }
 
   return YES;
 }
 
 - (NSArray*)customWindowsToEnterFullScreenForWindow:(NSWindow*)window {
   DCHECK([window isEqual:self.window]);
 
-  if (![self shouldUseCustomAppKitFullscreenTransition])
+  if (![self shouldUseCustomAppKitFullscreenTransition:YES])
     return nil;
 
   FramedBrowserWindow* framedBrowserWindow =
       base::mac::ObjCCast<FramedBrowserWindow>([self window]);
   fullscreenTransition_.reset([[BrowserWindowFullscreenTransition alloc]
       initEnterWithWindow:framedBrowserWindow]);
   return [fullscreenTransition_ customWindowsForFullScreenTransition];
 }
 
 - (NSArray*)customWindowsToExitFullScreenForWindow:(NSWindow*)window {
   DCHECK([window isEqual:self.window]);
 
-  if (![self shouldUseCustomAppKitFullscreenTransition])
+  if (![self shouldUseCustomAppKitFullscreenTransition:NO])
     return nil;
 
   FramedBrowserWindow* framedBrowserWindow =
       base::mac::ObjCCast<FramedBrowserWindow>([self window]);
   fullscreenTransition_.reset([[BrowserWindowFullscreenTransition alloc]
       initExitWithWindow:framedBrowserWindow
                    frame:savedRegularWindowFrame_]);
 
   return [fullscreenTransition_ customWindowsForFullScreenTransition];
 }
@@ skipping 22 matching lines @@
   return browser_->tab_strip_model()->GetActiveWebContents();
 }
 
 - (PermissionBubbleManager*)permissionBubbleManager {
   if (WebContents* contents = [self webContents])
     return PermissionBubbleManager::FromWebContents(contents);
   return nil;
 }
 
 @end  // @implementation BrowserWindowController(Private)