Fix nested config in GN.

Fix nested config in GN.

This also moves the config out of the template. Otherwise this will generate an
error if there is more than one MIDL target in the same directory.

Use forward_variables_from in the MIDL template.

TBR=dpranke@chromium.org

Committed: https://crrev.com/7c0c67ed3859656cb869fb517527938f70ed0cc6
Cr-Commit-Position: refs/heads/master@{#348664}

[brettw, 2015-09-11 20:49:46]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-09-11 20:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335283002/20001

[Dirk Pranke, 2015-09-11 20:53:01]

https://codereview.chromium.org/1335283002/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/1335283002/diff/20001/build/config/win/BUILD....
build/config/win/BUILD.gn:207: }
What's the advantage to putting this here over leaving it in midl.gni?

[brettw, 2015-09-11 20:58:12]

https://codereview.chromium.org/1335283002/diff/20001/build/config/win/BUILD.gn
File build/config/win/BUILD.gn (right):

https://codereview.chromium.org/1335283002/diff/20001/build/config/win/BUILD....
build/config/win/BUILD.gn:207: }
The old way will make a new config every time you call midl(). This will fail if
you do midl() more than once, and will generate duplicate but identical configs
all over the tree.

[Dirk Pranke, 2015-09-11 21:16:36]

On 2015/09/11 20:58:12, brettw wrote:
>
https://codereview.chromium.org/1335283002/diff/20001/build/config/win/BUILD.gn
> File build/config/win/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1335283002/diff/20001/build/config/win/BUILD....
> build/config/win/BUILD.gn:207: }
> The old way will make a new config every time you call midl(). This will fail
if
> you do midl() more than once, and will generate duplicate but identical
configs
> all over the tree.

So .gni files should not define configs, generally?

[commit-bot: I haz the power, 2015-09-11 22:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-11 22:25:49]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-09-11 22:49:59]

On 2015/09/11 21:16:36, Dirk Pranke wrote:
> So .gni files should not define configs, generally?

Rather: don't define non-varying configs in a template (just define it once so
things aren't duplicated), and if you do define a config in a template that
actually does vary according to the template parameters, its name needs to also
vary according to the template target_name.

[brettw, 2015-09-11 22:50:02]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-09-11 22:50:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335283002/20001

[commit-bot: I haz the power, 2015-09-11 23:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-11 23:08:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-09-14 17:58:07]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:59:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1335283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1335283002/20001

[commit-bot: I haz the power, 2015-09-14 18:38:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-14 18:39:56]

Patchset 2 (id:??) landed as
https://crrev.com/7c0c67ed3859656cb869fb517527938f70ed0cc6
Cr-Commit-Position: refs/heads/master@{#348664}

[commit-bot: I haz the power, 2015-09-23 12:34:47]

Patchset 2 (id:??) landed as
https://crrev.com/7c0c67ed3859656cb869fb517527938f70ed0cc6
Cr-Commit-Position: refs/heads/master@{#348664}