Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: build/config/win/BUILD.gn

Issue 1335283002: Fix nested config in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/win/midl.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build/config/win/visual_studio_version.gni") 6 import("//build/config/win/visual_studio_version.gni")
7 7
8 # Compiler setup for the Windows SDK. Applied to all targets. 8 # Compiler setup for the Windows SDK. Applied to all targets.
9 config("sdk") { 9 config("sdk") {
10 # The include path is the stuff returned by the script. 10 # The include path is the stuff returned by the script.
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 config("target_winrt") { 188 config("target_winrt") {
189 defines = [ 189 defines = [
190 "WINRT", 190 "WINRT",
191 "WINAPI_FAMILY=WINAPI_FAMILY_PC_APP", 191 "WINAPI_FAMILY=WINAPI_FAMILY_PC_APP",
192 ] 192 ]
193 cflags_cc = [ 193 cflags_cc = [
194 "/ZW", 194 "/ZW",
195 "/EHsc", 195 "/EHsc",
196 ] 196 ]
197 } 197 }
198
199 # Internal stuff --------------------------------------------------------------
200
201 # Config used by the MIDL template to disable warnings.
202 config("midl_warnings") {
203 if (is_clang) {
204 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
205 cflags = [ "-Wno-extra-tokens" ]
206 }
207 }
Dirk Pranke 2015/09/11 20:53:01 What's the advantage to putting this here over lea
brettw 2015/09/11 20:58:12 The old way will make a new config every time you
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/win/midl.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698