Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1335243002: Improve Uniform*ui{v} command handling. (Closed)

Created:
5 years, 3 months ago by Zhenyao Mo
Modified:
5 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), no sievers, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve Uniform*ui{v} command handling. BUG=429053 TEST=gpu_unittests R=piman@chromium.org Committed: https://crrev.com/7914825989b94d8ec3b9948a00a0915c9f737c9e Cr-Commit-Position: refs/heads/master@{#348714}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -139 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 5 chunks +13 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 5 chunks +66 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 8 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 4 chunks +8 lines, -120 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +24 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 5 chunks +60 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 2 chunks +139 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 chunks +19 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335243002/1
5 years, 3 months ago (2015-09-11 18:29:08 UTC) #2
Zhenyao Mo
piman: PTAL Others: FYI With this CL, gl-object-get-calles.html no longer crash in WebGL 2 conformance ...
5 years, 3 months ago (2015-09-11 18:29:46 UTC) #3
Ken Russell (switch to Gerrit)
Nice work.
5 years, 3 months ago (2015-09-11 18:42:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 19:36:59 UTC) #7
bajones
LGTM.
5 years, 3 months ago (2015-09-11 19:38:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335243002/20001
5 years, 3 months ago (2015-09-11 21:24:21 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/51970)
5 years, 3 months ago (2015-09-11 21:46:57 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335243002/20001
5 years, 3 months ago (2015-09-12 00:07:59 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/52079) linux_chromium_chromeos_compile_dbg_ng on ...
5 years, 3 months ago (2015-09-12 03:16:21 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335243002/20001
5 years, 3 months ago (2015-09-12 03:29:05 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/68971)
5 years, 3 months ago (2015-09-12 06:31:27 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335243002/20001
5 years, 3 months ago (2015-09-14 16:47:27 UTC) #22
Zhenyao Mo
piman: do you have more comments?
5 years, 3 months ago (2015-09-14 17:10:14 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 18:08:10 UTC) #25
piman
lgtm
5 years, 3 months ago (2015-09-14 20:16:41 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335243002/20001
5 years, 3 months ago (2015-09-14 20:32:55 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 20:42:21 UTC) #30
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7914825989b94d8ec3b9948a00a0915c9f737c9e Cr-Commit-Position: refs/heads/master@{#348714}
5 years, 3 months ago (2015-09-14 20:43:09 UTC) #31
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:37:03 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7914825989b94d8ec3b9948a00a0915c9f737c9e
Cr-Commit-Position: refs/heads/master@{#348714}

Powered by Google App Engine
This is Rietveld 408576698