Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1341133002: Add GL_TRANSFORM_FEEDBACK_BUFFER_MODE to GetProgramiv query. (Closed)

Created:
5 years, 3 months ago by Zhenyao Mo
Modified:
5 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@uniform
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GL_TRANSFORM_FEEDBACK_BUFFER_MODE to GetProgramiv query. It's simply an overlook in previous CLs. BUG=429053 TEST=gpu_unittests, webgl2_conformance R=piman@chromium.org Committed: https://crrev.com/6e2bb1f1a489c4b3cae0ea8e7f819ae93c3f54c6 Cr-Commit-Position: refs/heads/master@{#348759}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M gpu/command_buffer/client/program_info_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager.cc View 5 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/program_info_manager_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 3 chunks +10 lines, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 5 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341133002/20001
5 years, 3 months ago (2015-09-14 20:56:54 UTC) #2
Zhenyao Mo
piman, kbr: PTAL I discovered this bug by running one of the WebGL2 conformance tests. ...
5 years, 3 months ago (2015-09-14 20:56:57 UTC) #4
piman
lgtm
5 years, 3 months ago (2015-09-14 22:11:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 23:06:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341133002/20001
5 years, 3 months ago (2015-09-14 23:08:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 23:19:02 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6e2bb1f1a489c4b3cae0ea8e7f819ae93c3f54c6 Cr-Commit-Position: refs/heads/master@{#348759}
5 years, 3 months ago (2015-09-14 23:19:44 UTC) #11
Ken Russell (switch to Gerrit)
Excellent. LGTM after the fact.
5 years, 3 months ago (2015-09-15 01:02:40 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e2bb1f1a489c4b3cae0ea8e7f819ae93c3f54c6
Cr-Commit-Position: refs/heads/master@{#348759}

Powered by Google App Engine
This is Rietveld 408576698