Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3739)

Unified Diff: build/android/provision_devices.py

Issue 1334973002: Add date mismatch logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use isoformat(). Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/provision_devices.py
diff --git a/build/android/provision_devices.py b/build/android/provision_devices.py
index 0a7f8fd770f8b24a6ca464942a0a9d148229753a..48f52081559fa5be00af17d14733ac4a675d1c97 100755
--- a/build/android/provision_devices.py
+++ b/build/android/provision_devices.py
@@ -319,6 +319,8 @@ def FinishProvisioning(device, options):
logging.info('Date/time successfully set on %s', device)
return True
else:
+ logging.error('Date mismatch. Device: %s Correct: %s' % (
jbudorick 2015/09/10 22:46:04 I'm not sure how this cleared the linter (when was
ghost stip (do not use) 2015/09/10 23:19:49 good point, I always forget the logging module can
jbudorick 2015/09/10 23:24:26 Then you probably hadn't synced this week :) I ad
+ device_time.isoformat(), correct_time.isoformat()))
return False
# Sometimes the date is not set correctly on the devices. Retry on failure.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698