Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1334973002:
Add date mismatch logging. (Closed)
|
Created:
5 years, 3 months ago by ghost stip (do not use) Modified:
5 years, 2 months ago Reviewers:
jbudorick CC:
bpastene, chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, luqui, martiniss, yfriedman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd date mismatch logging.
BUG=528647
Committed: https://crrev.com/409b2a3d4b2c52578477a979e50eb23334e96c43
Cr-Commit-Position: refs/heads/master@{#348296}
Patch Set 1 #Patch Set 2 : Use isoformat(). #
Total comments: 3
Patch Set 3 : Update logging syntax. #Messages
Total messages: 14 (3 generated)
stip@chromium.org changed reviewers: + jbudorick@chromium.org
ptal
https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... File build/android/provision_devices.py (right): https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... build/android/provision_devices.py:322: logging.error('Date mismatch. Device: %s Correct: %s' % ( I'm not sure how this cleared the linter (when was the last time you synced?), but this should be logging.error('...', device_time.isoformat(), correct_time.isoformat())
On 2015/09/10 at 22:46:04, jbudorick wrote: > https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... > File build/android/provision_devices.py (right): > > https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... > build/android/provision_devices.py:322: logging.error('Date mismatch. Device: %s Correct: %s' % ( > I'm not sure how this cleared the linter (when was the last time you synced?), but this should be > > logging.error('...', device_time.isoformat(), correct_time.isoformat()) (lgtm after that, though)
https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... File build/android/provision_devices.py (right): https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... build/android/provision_devices.py:322: logging.error('Date mismatch. Device: %s Correct: %s' % ( On 2015/09/10 22:46:04, jbudorick wrote: > I'm not sure how this cleared the linter (when was the last time you synced?), > but this should be > > logging.error('...', device_time.isoformat(), correct_time.isoformat()) good point, I always forget the logging module can do that. no answer on the linter though, I just did your stock `git cl upload`
https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... File build/android/provision_devices.py (right): https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... build/android/provision_devices.py:322: logging.error('Date mismatch. Device: %s Correct: %s' % ( On 2015/09/10 at 23:19:49, stip wrote: > On 2015/09/10 22:46:04, jbudorick wrote: > > I'm not sure how this cleared the linter (when was the last time you synced?), > > but this should be > > > > logging.error('...', device_time.isoformat(), correct_time.isoformat()) > > good point, I always forget the logging module can do that. no answer on the linter though, I just did your stock `git cl upload` Then you probably hadn't synced this week :) I added a new pylintrc for build/android/ in https://codereview.chromium.org/1315743004.
On 2015/09/10 23:24:26, jbudorick wrote: > https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... > File build/android/provision_devices.py (right): > > https://codereview.chromium.org/1334973002/diff/20001/build/android/provision... > build/android/provision_devices.py:322: logging.error('Date mismatch. Device: %s > Correct: %s' % ( > On 2015/09/10 at 23:19:49, stip wrote: > > On 2015/09/10 22:46:04, jbudorick wrote: > > > I'm not sure how this cleared the linter (when was the last time you > synced?), > > > but this should be > > > > > > logging.error('...', device_time.isoformat(), correct_time.isoformat()) > > > > good point, I always forget the logging module can do that. no answer on the > linter though, I just did your stock `git cl upload` > > Then you probably hadn't synced this week :) > > I added a new pylintrc for build/android/ in > https://codereview.chromium.org/1315743004. https://www.youtube.com/watch?v=5es0NNtSNCU
The CQ bit was checked by stip@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://chromiumcodereview.appspot.com/1334973002/#ps40001 (title: "Update logging syntax.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334973002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/409b2a3d4b2c52578477a979e50eb23334e96c43 Cr-Commit-Position: refs/heads/master@{#348296}
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/409b2a3d4b2c52578477a979e50eb23334e96c43 Cr-Commit-Position: refs/heads/master@{#348296} |
