Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1334873002: MIPS: [Interpreter] Add support for JS calls. (Closed)

Created:
5 years, 3 months ago by akos.palfi.imgtec
Modified:
5 years, 3 months ago
Reviewers:
paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [Interpreter] Add support for JS calls. Port of https://codereview.chromium.org/1323463005/ BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
paul.l...
l-g-t-m for inclusion in https://codereview.chromium.org/1323463005/ (but do note the test fail that Ákos mentioned there).
5 years, 3 months ago (2015-09-11 02:18:12 UTC) #2
rmcilroy
5 years, 3 months ago (2015-09-11 13:33:00 UTC) #3
On 2015/09/11 02:18:12, paul.l... wrote:
> l-g-t-m for inclusion in https://codereview.chromium.org/1323463005/ (but do
> note the test fail that Ákos mentioned there).

Thanks for the port, included in https://codereview.chromium.org/1323463005/.
The test failure was a bug in the test (and TurboFan interaction), more
discussed on the other CL.

Powered by Google App Engine
This is Rietveld 408576698