Issue 133483002: Fix idle handlers not being called. The problem was that RenderThread::AddRoute was assuming that e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133483002: Fix idle handlers not being called. The problem was that RenderThread::AddRoute was assuming that e… (Closed)

Created:
6 years, 11 months ago by jam

Modified:
6 years, 11 months ago

Reviewers:
nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix idle handlers not being called. The problem was that RenderThread::AddRoute was assuming that each listener was a RenderWidget. That used to be the case originally, but hasn't been like that for a while (i.e. also see ChromeV8ExtensionHandler and ChromePluginPlaceholder). BUG=333051 R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244193

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : sync #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -70 lines)			Patch
M	content/public/renderer/render_thread.h	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/test/mock_render_thread.h	View	1 2 3	3 chunks	+0 lines, -11 lines	0 comments	Download
M	content/public/test/mock_render_thread.cc	View	1 2 3	4 chunks	+2 lines, -15 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View	1 2 3	2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2 3	3 chunks	+37 lines, -32 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2 3	1 chunk	+5 lines, -2 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1 2 3	3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages