Fix idle handlers not being called. The problem was that RenderThread::AddRoute was assuming that e…

content/public/test/mock_render_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_MOCK_RENDER_THREAD_H_
 #define CONTENT_PUBLIC_TEST_MOCK_RENDER_THREAD_H_
 
 #include "base/memory/shared_memory.h"
 #include "base/observer_list.h"
 #include "base/strings/string16.h"
@@ skipping 37 matching lines @@
       OVERRIDE;
   virtual void AddRoute(int32 routing_id, IPC::Listener* listener) OVERRIDE;
   virtual void RemoveRoute(int32 routing_id) OVERRIDE;
   virtual int GenerateRoutingID() OVERRIDE;
   virtual void AddFilter(IPC::ChannelProxy::MessageFilter* filter) OVERRIDE;
   virtual void RemoveFilter(IPC::ChannelProxy::MessageFilter* filter) OVERRIDE;
   virtual void AddObserver(RenderProcessObserver* observer) OVERRIDE;
   virtual void RemoveObserver(RenderProcessObserver* observer) OVERRIDE;
   virtual void SetResourceDispatcherDelegate(
       ResourceDispatcherDelegate* delegate) OVERRIDE;
-  virtual void WidgetHidden() OVERRIDE;
-  virtual void WidgetRestored() OVERRIDE;
   virtual void EnsureWebKitInitialized() OVERRIDE;
   virtual void RecordAction(const UserMetricsAction& action) OVERRIDE;
   virtual void RecordComputedAction(const std::string& action) OVERRIDE;
   virtual scoped_ptr<base::SharedMemory> HostAllocateSharedMemoryBuffer(
       size_t buffer_size) OVERRIDE;
   virtual void RegisterExtension(v8::Extension* extension) OVERRIDE;
   virtual void ScheduleIdleHandler(int64 initial_delay_ms) OVERRIDE;
   virtual void IdleHandler() OVERRIDE;
   virtual int64 GetIdleNotificationDelayInMs() const OVERRIDE;
   virtual void SetIdleNotificationDelayInMs(
@@ skipping 15 matching lines @@
   }
 
   void set_surface_id(int32 id) {
     surface_id_ = id;
   }
 
   int32 opener_id() const {
     return opener_id_;
   }
 
-  bool has_widget() const {
-    return (widget_ != NULL);
-  }
-
   void set_new_window_routing_id(int32 id) {
     new_window_routing_id_ = id;
   }
 
   void set_new_frame_routing_id(int32 id) {
     new_frame_routing_id_ = id;
   }
 
   // Simulates the Widget receiving a close message. This should result
   // on releasing the internal reference counts and destroying the internal
@@ skipping 40 matching lines @@
 
   // Routing id what will be assigned to the Widget.
   int32 routing_id_;
 
   // Surface id what will be assigned to the Widget.
   int32 surface_id_;
 
   // Opener id reported by the Widget.
   int32 opener_id_;
 
-  // We only keep track of one Widget, we learn its pointer when it
-  // adds a new route.  We do not keep track of Widgets created with
-  // OnCreateWindow.
-  IPC::Listener* widget_;
-
   // Routing id that will be assigned to a CreateWindow Widget.
   int32 new_window_routing_id_;
   int32 new_window_main_frame_routing_id_;
   int32 new_frame_routing_id_;
 
   // The last known good deserializer for sync messages.
   scoped_ptr<IPC::MessageReplyDeserializer> reply_deserializer_;
 
   // A list of message filters added to this thread.
   std::vector<scoped_refptr<IPC::ChannelProxy::MessageFilter> > filters_;
 
   // Observers to notify.
   ObserverList<RenderProcessObserver> observers_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_MOCK_RENDER_THREAD_H_