Issue 1334633004: Merge to XFA: Fix JS_GetArrayElement to not return an empty handle on success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1334633004: Merge to XFA: Fix JS_GetArrayElement to not return an empty handle on success (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez, ulan

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix JS_GetArrayElement to not return an empty handle on success BUG=chromium:528376 TBR=ulan@chromium.org, tsepez@chromium.org Original Review URL: https://codereview.chromium.org/1337433002 . (cherry picked from commit 0d0935d3d6603dd7d851b1d5828635230f4c43ca) Committed: https://pdfium.googlesource.com/pdfium/+/ab54bc0f66ca3130ea4780580060f75f20c12234

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

jochen (gone - plz use gerrit)

5 years, 3 months ago (2015-09-10 11:46:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab54bc0f66ca3130ea4780580060f75f20c12234 (presubmit successful).