Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1337433002: Fix JS_GetArrayElement to not return an empty handle on success (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez, ulan
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jochen (gone - plz use gerrit)
ptal not sure it's ok to include the pdf for the embedder test here.
5 years, 3 months ago (2015-09-10 09:40:29 UTC) #1
ulan
lgtm
5 years, 3 months ago (2015-09-10 11:40:34 UTC) #3
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-10 11:44:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d0935d3d6603dd7d851b1d5828635230f4c43ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698