Add GPU fingerprint information to breakpad microdumps.

src/client/linux/handler/minidump_descriptor.h

Index: src/client/linux/handler/minidump_descriptor.h
diff --git a/src/client/linux/handler/minidump_descriptor.h b/src/client/linux/handler/minidump_descriptor.h
index 3584c6922a34f885f7cf510e372fdce460a9cf27..d69d8e721cef51deb96479c44c5a715e03ebd31c 100644
--- a/src/client/linux/handler/minidump_descriptor.h
+++ b/src/client/linux/handler/minidump_descriptor.h
@@ -53,7 +53,8 @@ class MinidumpDescriptor {
                          fd_(-1),
                          size_limit_(-1),
                          microdump_build_fingerprint_(NULL),
-                         microdump_product_info_(NULL) {}
+                         microdump_product_info_(NULL),
+                         microdump_gpu_fingerprint_(NULL) {}
 
   explicit MinidumpDescriptor(const string& directory)
       : mode_(kWriteMinidumpToFile),
@@ -62,7 +63,8 @@ class MinidumpDescriptor {
         c_path_(NULL),
         size_limit_(-1),
         microdump_build_fingerprint_(NULL),
-        microdump_product_info_(NULL) {
+        microdump_product_info_(NULL),
+        microdump_gpu_fingerprint_(NULL) {
     assert(!directory.empty());
   }
 
@@ -72,7 +74,8 @@ class MinidumpDescriptor {
         c_path_(NULL),
         size_limit_(-1),
         microdump_build_fingerprint_(NULL),
-        microdump_product_info_(NULL) {
+        microdump_product_info_(NULL),
+        microdump_gpu_fingerprint_(NULL) {
     assert(fd != -1);
   }
 
@@ -81,7 +84,8 @@ class MinidumpDescriptor {
         fd_(-1),
         size_limit_(-1),
         microdump_build_fingerprint_(NULL),
-        microdump_product_info_(NULL) {}
+        microdump_product_info_(NULL),
+        microdump_gpu_fingerprint_(NULL) {}
 
   explicit MinidumpDescriptor(const MinidumpDescriptor& descriptor);
   MinidumpDescriptor& operator=(const MinidumpDescriptor& descriptor);
@@ -119,6 +123,11 @@ class MinidumpDescriptor {
     return microdump_product_info_;
   }
 
+  void SetMicrodumpGPUFingerprint(const char* gpu_fingerprint);

[Primiano Tucci (use gerrit), 2015/09/09 18:59:34]

At this point feels like we should just have one method which is:
SetMicrodumpMetadata which takes a struct. So the next time we need something
more (my guts say won't take too long) we don't have to repeat all this plumbing
again (and risk to forget to plumb the NULL assignments). WDYT?

Also this could resolve the todo above.
Welcome to: "since you're changing this, would you mind also..." :)

[Tobias Sargeant, 2015/09/10 10:45:04]

Done.

+  const char* microdump_gpu_fingerprint() const {
+    return microdump_gpu_fingerprint_;
+  }
+
  private:
   enum DumpMode {
     kUninitialized = 0,
@@ -154,6 +163,7 @@ class MinidumpDescriptor {
   // global static storage).
   const char* microdump_build_fingerprint_;
   const char* microdump_product_info_;
+  const char* microdump_gpu_fingerprint_;
 };
 
 }  // namespace google_breakpad