Add GPU fingerprint information to breakpad microdumps.

src/client/linux/handler/minidump_descriptor.h

 // Copyright (c) 2012 Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 35 matching lines @@
 
 class MinidumpDescriptor {
  public:
   struct MicrodumpOnConsole {};
   static const MicrodumpOnConsole kMicrodumpOnConsole;
 
   MinidumpDescriptor() : mode_(kUninitialized),
                          fd_(-1),
                          size_limit_(-1),
                          microdump_build_fingerprint_(NULL),
-                         microdump_product_info_(NULL) {}
+                         microdump_product_info_(NULL),
+                         microdump_gpu_fingerprint_(NULL) {}
 
   explicit MinidumpDescriptor(const string& directory)
       : mode_(kWriteMinidumpToFile),
         fd_(-1),
         directory_(directory),
         c_path_(NULL),
         size_limit_(-1),
         microdump_build_fingerprint_(NULL),
-        microdump_product_info_(NULL) {
+        microdump_product_info_(NULL),
+        microdump_gpu_fingerprint_(NULL) {
     assert(!directory.empty());
   }
 
   explicit MinidumpDescriptor(int fd)
       : mode_(kWriteMinidumpToFd),
         fd_(fd),
         c_path_(NULL),
         size_limit_(-1),
         microdump_build_fingerprint_(NULL),
-        microdump_product_info_(NULL) {
+        microdump_product_info_(NULL),
+        microdump_gpu_fingerprint_(NULL) {
     assert(fd != -1);
   }
 
   explicit MinidumpDescriptor(const MicrodumpOnConsole&)
       : mode_(kWriteMicrodumpToConsole),
         fd_(-1),
         size_limit_(-1),
         microdump_build_fingerprint_(NULL),
-        microdump_product_info_(NULL) {}
+        microdump_product_info_(NULL),
+        microdump_gpu_fingerprint_(NULL) {}
 
   explicit MinidumpDescriptor(const MinidumpDescriptor& descriptor);
   MinidumpDescriptor& operator=(const MinidumpDescriptor& descriptor);
 
   static MinidumpDescriptor getMicrodumpDescriptor();
 
   bool IsFD() const { return mode_ == kWriteMinidumpToFd; }
 
   int fd() const { return fd_; }
 
@@ skipping 17 matching lines @@
   void SetMicrodumpBuildFingerprint(const char* build_fingerprint);
   const char* microdump_build_fingerprint() const {
     return microdump_build_fingerprint_;
   }
 
   void SetMicrodumpProductInfo(const char* product_info);
   const char* microdump_product_info() const {
     return microdump_product_info_;
   }
 
+  void SetMicrodumpGPUFingerprint(const char* gpu_fingerprint);

[Primiano Tucci (use gerrit), 2015/09/09 18:59:34]

At this point feels like we should just have one method which is:
SetMicrodumpMetadata which takes a struct. So the next time we need something
more (my guts say won't take too long) we don't have to repeat all this plumbing
again (and risk to forget to plumb the NULL assignments). WDYT?

Also this could resolve the todo above.
Welcome to: "since you're changing this, would you mind also..." :)

[Tobias Sargeant, 2015/09/10 10:45:04]

Done.

+  const char* microdump_gpu_fingerprint() const {
+    return microdump_gpu_fingerprint_;
+  }
+
  private:
   enum DumpMode {
     kUninitialized = 0,
     kWriteMinidumpToFile,
     kWriteMinidumpToFd,
     kWriteMicrodumpToConsole
   };
 
   // Specifies the dump mode (see DumpMode).
   DumpMode mode_;
@@ skipping 15 matching lines @@
 
   // The product name/version and build fingerprint that should be appended to
   // the dump (microdump only). Microdumps don't have the ability of appending
   // extra metadata after the dump is generated (as opposite to minidumps
   // MIME fields), therefore the product details must be provided upfront.
   // The string pointers are supposed to be valid through all the lifetime of
   // the process (read: the caller has to guarantee that they are stored in
   // global static storage).
   const char* microdump_build_fingerprint_;
   const char* microdump_product_info_;
+  const char* microdump_gpu_fingerprint_;
 };
 
 }  // namespace google_breakpad
 
 #endif  // CLIENT_LINUX_HANDLER_MINIDUMP_DESCRIPTOR_H_