Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: public/web/WebAutofillClient.h

Issue 133443011: Add text field change handling for autofill preview in textarea element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Wrap text Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebAutofillClient.h
diff --git a/public/web/WebAutofillClient.h b/public/web/WebAutofillClient.h
index 8b13aa0c156330d76999cbcbbf4797d5bb032231..347b6926bdce7a4b176f961c6dc0b63ef2191059 100644
--- a/public/web/WebAutofillClient.h
+++ b/public/web/WebAutofillClient.h
@@ -33,6 +33,7 @@
namespace blink {
+class WebFormControlElement;
class WebFormElement;
class WebFrame;
class WebInputElement;
@@ -48,7 +49,7 @@ public:
// These methods are called when the users edits a text-field.
virtual void textFieldDidEndEditing(const WebInputElement&) { }
- virtual void textFieldDidChange(const WebInputElement&) { }
+ virtual void textFieldDidChange(const WebFormControlElement&) { }
tkent 2014/03/04 00:15:56 This will break build because Chromium has "textFi
jamesr 2014/03/04 00:26:33 If so then the bug is the OVERRIDE annotation on t
ziran.sun 2014/03/04 12:12:40 Do you mean add "textFieldDidChange(const WebInput
ziran.sun 2014/03/04 12:12:40 In the chromium side code for this bug, we removed
virtual void textFieldDidReceiveKeyDown(const WebInputElement&, const WebKeyboardEvent&) { }
// This is called when a datalist indicator is clicked.
virtual void openTextDataListChooser(const WebInputElement&) { }

Powered by Google App Engine
This is Rietveld 408576698