Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2010 Google Inc. All rights reserved. | 2 * Copyright (C) 2010 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
| 6 * met: | 6 * met: |
| 7 * | 7 * |
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 29 */ | 29 */ |
| 30 | 30 |
| 31 #ifndef WebAutofillClient_h | 31 #ifndef WebAutofillClient_h |
| 32 #define WebAutofillClient_h | 32 #define WebAutofillClient_h |
| 33 | 33 |
| 34 namespace blink { | 34 namespace blink { |
| 35 | 35 |
| 36 class WebFormControlElement; | |
| 36 class WebFormElement; | 37 class WebFormElement; |
| 37 class WebFrame; | 38 class WebFrame; |
| 38 class WebInputElement; | 39 class WebInputElement; |
| 39 class WebKeyboardEvent; | 40 class WebKeyboardEvent; |
| 40 class WebNode; | 41 class WebNode; |
| 41 | 42 |
| 42 template <typename T> class WebVector; | 43 template <typename T> class WebVector; |
| 43 | 44 |
| 44 class WebAutofillClient { | 45 class WebAutofillClient { |
| 45 public: | 46 public: |
| 46 // Informs the browser an interactive autocomplete has been requested. | 47 // Informs the browser an interactive autocomplete has been requested. |
| 47 virtual void didRequestAutocomplete(WebFrame*, const WebFormElement&) { } | 48 virtual void didRequestAutocomplete(WebFrame*, const WebFormElement&) { } |
| 48 | 49 |
| 49 // These methods are called when the users edits a text-field. | 50 // These methods are called when the users edits a text-field. |
| 50 virtual void textFieldDidEndEditing(const WebInputElement&) { } | 51 virtual void textFieldDidEndEditing(const WebInputElement&) { } |
| 51 virtual void textFieldDidChange(const WebInputElement&) { } | 52 virtual void textFieldDidChange(const WebFormControlElement&) { } |
|
tkent
2014/03/04 00:15:56
This will break build because Chromium has "textFi
jamesr
2014/03/04 00:26:33
If so then the bug is the OVERRIDE annotation on t
ziran.sun
2014/03/04 12:12:40
Do you mean add "textFieldDidChange(const
WebInput
ziran.sun
2014/03/04 12:12:40
In the chromium side code for this bug, we removed
| |
| 52 virtual void textFieldDidReceiveKeyDown(const WebInputElement&, const WebKey boardEvent&) { } | 53 virtual void textFieldDidReceiveKeyDown(const WebInputElement&, const WebKey boardEvent&) { } |
| 53 // This is called when a datalist indicator is clicked. | 54 // This is called when a datalist indicator is clicked. |
| 54 virtual void openTextDataListChooser(const WebInputElement&) { } | 55 virtual void openTextDataListChooser(const WebInputElement&) { } |
| 55 | 56 |
| 56 // Informs the client whether or not any subsequent text changes should be i gnored. | 57 // Informs the client whether or not any subsequent text changes should be i gnored. |
| 57 virtual void setIgnoreTextChanges(bool ignore) { } | 58 virtual void setIgnoreTextChanges(bool ignore) { } |
| 58 | 59 |
| 59 virtual void didAssociateFormControls(const WebVector<WebNode>&) { } | 60 virtual void didAssociateFormControls(const WebVector<WebNode>&) { } |
| 60 | 61 |
| 61 protected: | 62 protected: |
| 62 virtual ~WebAutofillClient() { } | 63 virtual ~WebAutofillClient() { } |
| 63 }; | 64 }; |
| 64 | 65 |
| 65 } // namespace blink | 66 } // namespace blink |
| 66 | 67 |
| 67 #endif | 68 #endif |
| OLD | NEW |