Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: Source/core/dom/Text.cpp

Issue 1334373002: Don't allow whitespace between elements with display:table-cell (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2454
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/linux/tables/mozilla/bugs/bug2479-1-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Text.cpp
diff --git a/Source/core/dom/Text.cpp b/Source/core/dom/Text.cpp
index 71ce46fafe31b261b867f458704327e75b04cf5b..ebf787adbfae94595a2cc94387cf321c8cd5901b 100644
--- a/Source/core/dom/Text.cpp
+++ b/Source/core/dom/Text.cpp
@@ -251,15 +251,18 @@ static inline bool hasGeneratedAnonymousTableCells(const LayoutObject& parent)
return false;
}
-static inline bool canHaveWhitespaceChildren(const LayoutObject& parent)
+static inline bool nodeAllowsAdjacentWhitespace(Node* node)
{
- // <button> should allow whitespace even though LayoutFlexibleBox doesn't.
- if (parent.isLayoutButton())
+ if (!node)
return true;
+ const ComputedStyle* style = node->ensureComputedStyle();
+ return style && style->originalDisplay() != TABLE_CELL && !isHTMLTableCellElement(node);
+}
- // Allow whitespace when the text is inside a table, section or row element that
- // has generated anonymous table cells to hold its contents.
- if (hasGeneratedAnonymousTableCells(parent))
+static inline bool canHaveWhitespaceChildren(const LayoutObject& parent, Text* text)
+{
+ // <button> should allow whitespace even though LayoutFlexibleBox doesn't.
+ if (parent.isLayoutButton())
return true;
if (parent.isTable() || parent.isTableRow() || parent.isTableSection()
@@ -268,8 +271,13 @@ static inline bool canHaveWhitespaceChildren(const LayoutObject& parent)
|| parent.isSVGRoot()
|| parent.isSVGContainer()
|| parent.isSVGImage()
- || parent.isSVGShape())
+ || parent.isSVGShape()) {
+ // Allow whitespace when the text is inside a table, section or row element that
+ // has generated anonymous table cells to hold its contents.
+ if (hasGeneratedAnonymousTableCells(parent))
+ return nodeAllowsAdjacentWhitespace(text->previousSibling()) && nodeAllowsAdjacentWhitespace(text->nextSibling());
return false;
+ }
return true;
}
@@ -290,7 +298,7 @@ bool Text::textLayoutObjectIsNeeded(const ComputedStyle& style, const LayoutObje
if (!containsOnlyWhitespace())
return true;
- if (!canHaveWhitespaceChildren(parent))
+ if (!canHaveWhitespaceChildren(parent, this))
return false;
// pre-wrap in SVG never makes layoutObject.
« no previous file with comments | « LayoutTests/platform/linux/tables/mozilla/bugs/bug2479-1-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698