chrome/browser/app_controller_mac.mm - Issue 1334363002: [Eraser] First pass at removing the notification center panel.

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 1334363002: [Eraser] First pass at removing the notification center panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moar fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/background/background_contents_service_unittest.cc » ('j') | chrome/browser/notifications/message_center_notification_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 0b290319d87e3800626160965fe15b718cc8b9a5..6cdc335a3006d1b20aac4dbec067d753c2e0a71b 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -212,7 +212,6 @@ bool IsProfileSignedOut(Profile* profile) {

- (void)initMenuState;

- (void)initProfileMenu;

- (void)updateConfirmToQuitPrefMenuItem:(NSMenuItem*)item;

-- (void)updateDisplayMessageCenterPrefMenuItem:(NSMenuItem*)item;

- (void)registerServicesMenuTypesTo:(NSApplication*)app;

- (void)getUrl:(NSAppleEventDescriptor*)event

withReply:(NSAppleEventDescriptor*)reply;

@@ -1000,9 +999,7 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {

[self updateConfirmToQuitPrefMenuItem:static_cast<NSMenuItem*>(item)];

enable = YES;

} else if (action == @selector(toggleDisplayMessageCenter:)) {

- NSMenuItem* menuItem = static_cast<NSMenuItem*>(item);

- [self updateDisplayMessageCenterPrefMenuItem:menuItem];

- enable = YES;

+ enable = NO;

Robert Sesek 2015/09/15 22:07:08 Leave a TODO and point to the bug # ?

dewittj 2015/09/15 22:52:22 Done.

} else if (action == @selector(executeApplication:)) {

enable = YES;

}

@@ -1327,11 +1324,6 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {

}

- (void)updateDisplayMessageCenterPrefMenuItem:(NSMenuItem*)item {

Robert Sesek 2015/09/15 22:07:08 You can remove this. Only the -toggle… method is r

dewittj 2015/09/15 22:52:22 Done.

- const PrefService* prefService = g_browser_process->local_state();

- bool enabled = prefService->GetBoolean(prefs::kMessageCenterShowIcon);

- // The item should be checked if "show icon" is false, since the text reads

- // "Hide notification center icon."

- [item setState:enabled ? NSOffState : NSOnState];

}

- (void)registerServicesMenuTypesTo:(NSApplication*)app {

@@ -1467,9 +1459,6 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {

}

- (IBAction)toggleDisplayMessageCenter:(id)sender {

- PrefService* prefService = g_browser_process->local_state();

- bool enabled = prefService->GetBoolean(prefs::kMessageCenterShowIcon);

- prefService->SetBoolean(prefs::kMessageCenterShowIcon, !enabled);

}

// Explicitly bring to the foreground when creating new windows from the dock.